Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had some issues when trying to load a json save where some tiles had railroads. As far as I can tell, this happens, because when we save the overlays, if there is a railroad, we don't save the road that invisibly exists underneath it.
So then, when loading, we try to add railroad to a tile that doesn't seem to have a road.
This does not happen with .biq and .sav files because when debugging I saw that we import both a road and a railroad overlay when laoding the tile info
So now, the only place where we check if we can add an improvement, is during gameplay and not when loading a save. I think it also makes sense from a cleaner code standpoint, to have a dedicated method to add an improvement, rather than also checking if we can add it in the same method.
I don't think that we need to imitate what the .biq and .sav files do and save both improvements, as we can upgrade and downgrade on the fly.