fix 06-inter-node-reduce-scatter.py tutorial bug#130
Open
AkiRusProd wants to merge 1 commit intoByteDance-Seed:mainfrom
Open
fix 06-inter-node-reduce-scatter.py tutorial bug#130AkiRusProd wants to merge 1 commit intoByteDance-Seed:mainfrom
AkiRusProd wants to merge 1 commit intoByteDance-Seed:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello!
In the
create_reduce_scater_2d_ctxmethod of 06-inter-node-reduce-scatter.py tutorial. the global process rank was used to index the signal_bufs list during the initialization of signal_buf.This resulted in an
IndexErroron any node other than the first (i.e., when rank >= local_world_size).What is the solution?
The indexing for the signal_bufs list has been corrected to use local_rank instead of the global rank:
This change ensures that each process on a node correctly accesses its dedicated signal buffer from the list of local buffers. It resolves the crash and enables the proper initialization of the communication context for multi-node environments.
NOTE:
from nvshmem_create_tensors:
so then
len(signal_bufs) = rank_on_same_node_end - rank_on_same_node_start = (rank_on_same_node_start + local_world_size) - rank_on_same_node_start = local_world_size