remove isTbcOnly from profile - #394
Merged
Merged
Conversation
Alessandro-Barbieri
marked this pull request as ready for review
January 13, 2026 02:29
Contributor
Author
|
not tested yet, am I going into the right direction? |
Alessandro-Barbieri
marked this pull request as draft
January 16, 2026 02:43
add draenei passive to ranged hit calculation
add vscode folder to gitignore
fix annotations
replace deprecated functions
Owner
|
@Alessandro-Barbieri you change a lot of stats to be visible across various expansions. Is that intended? Examples are Armor Pen (visible in every expansion with this PR) and Haste (visible in TBC and WotLK). |
Contributor
Author
it's intentional:
|
BreakBB
reviewed
Jan 26, 2026
Co-authored-by: Björn Heiß <b.boeing@online.de>
Open
BreakBB
reviewed
Feb 13, 2026
BreakBB
left a comment
BreakBB
left a comment
Owner
There was a problem hiding this comment.
Outside of these minor things, this PR looks good to me
Co-authored-by: Björn Heiß <b.boeing@online.de>
Alessandro-Barbieri
marked this pull request as ready for review
February 14, 2026 13:12
BreakBB
approved these changes
Feb 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
removed
isTbcOnlyswapped the logic on many expansion checks