ENH: Dream3dImportParameter supports additional import options.#1230
Merged
imikejackson merged 17 commits intoBlueQuartzSoftware:developfrom Mar 26, 2025
Merged
Conversation
joeykleingers
force-pushed
the
topic/Dream3dImportParameterEnh
branch
from
828b4e4 to
093921a
Compare
imikejackson
force-pushed
the
topic/Dream3dImportParameterEnh
branch
from
093921a to
07d434d
Compare
joeykleingers
force-pushed
the
topic/Dream3dImportParameterEnh
branch
3 times, most recently
from
ce5be47 to
3c0fbbd
Compare
imikejackson
force-pushed
the
topic/Dream3dImportParameterEnh
branch
3 times, most recently
from
0d2021a to
bf0353d
Compare
joeykleingers
force-pushed
the
topic/Dream3dImportParameterEnh
branch
3 times, most recently
from
c6f0a1f to
274f25b
Compare
JDuffeyBQ
requested changes
Mar 18, 2025
imikejackson
force-pushed
the
topic/Dream3dImportParameterEnh
branch
2 times, most recently
from
60d6a33 to
b6d377b
Compare
joeykleingers
force-pushed
the
topic/Dream3dImportParameterEnh
branch
from
d832477 to
6f47ce8
Compare
joeykleingers
force-pushed
the
topic/Dream3dImportParameterEnh
branch
2 times, most recently
from
d4ec7af to
2d42181
Compare
JDuffeyBQ
approved these changes
Mar 20, 2025
Signed-off-by: Joey Kleingers <joey.kleingers@bluequartz.net>
Signed-off-by: Joey Kleingers <joey.kleingers@bluequartz.net>
Signed-off-by: Joey Kleingers <joey.kleingers@bluequartz.net>
Signed-off-by: Joey Kleingers <joey.kleingers@bluequartz.net>
…aths. This change allows the filter to handle "Geometry/CellData/Fit" by itself instead of having to also input "Geometry" and "Geometry/CellData". This change will mainly benefit anyone running this filter without the GUI. Signed-off-by: Joey Kleingers <joey.kleingers@bluequartz.net>
Signed-off-by: Joey Kleingers <joey.kleingers@bluequartz.net>
Signed-off-by: Joey Kleingers <joey.kleingers@bluequartz.net>
Signed-off-by: Joey Kleingers <joey.kleingers@bluequartz.net>
Signed-off-by: Joey Kleingers <joey.kleingers@bluequartz.net>
Signed-off-by: Joey Kleingers <joey.kleingers@bluequartz.net>
Signed-off-by: Joey Kleingers <joey.kleingers@bluequartz.net>
Co-authored-by: Jared Duffey <jared.duffey@bluequartz.net>
Co-authored-by: Jared Duffey <jared.duffey@bluequartz.net>
Co-authored-by: Jared Duffey <jared.duffey@bluequartz.net>
Co-authored-by: Jared Duffey <jared.duffey@bluequartz.net>
Co-authored-by: Jared Duffey <jared.duffey@bluequartz.net>
Signed-off-by: Joey Kleingers <joey.kleingers@bluequartz.net>
joeykleingers
force-pushed
the
topic/Dream3dImportParameterEnh
branch
from
2d42181 to
59f5e57
Compare
imikejackson
merged commit 90d09a4
into
BlueQuartzSoftware:develop
8 of 9 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a new member variable enumeration to the ImportData struct called PathImportPolicy, which has options "IncludeList", "ExcludeList", and "All". If IncludeList is chosen, the data paths are interpreted as paths to objects to import. If ExcludeList is chosen, the data paths are interpreted as paths to objects to NOT import. If All is chosen, the data paths are ignored and everything is imported.
Included a new constructor that is required to be used when creating a new ImportData instance.
Updated the ReadDREAM3DFileFilter to be able to take in paths to singular objects without also requiring all the parent paths too. For example, it is now possible to set the DataPaths to simply "ImageGeom/CellData/Confidence Index" without having to also include "ImageGeom" and "ImageGeom/CellData". This will be useful for anyone trying to execute this filter without the GUI, especially on the Python side.