BUG: Changes the Face Label value to -1 for boundary triangles in SurfaceNets#1188
Merged
imikejackson merged 1 commit intoBlueQuartzSoftware:developfrom Mar 11, 2025
Conversation
imikejackson
force-pushed
the
topic/change_surface_nets_face_labels
branch
2 times, most recently
from
d70b703 to
165ef6a
Compare
imikejackson
added
bug
imikejackson
force-pushed
the
topic/change_surface_nets_face_labels
branch
2 times, most recently
from
1d9488a to
b77ed3c
Compare
imikejackson
requested review from
JDuffeyBQ
and removed request for
nyoungbq
imikejackson
force-pushed
the
topic/change_surface_nets_face_labels
branch
3 times, most recently
from
1be3a12 to
ba4f4e0
Compare
imikejackson
force-pushed
the
topic/change_surface_nets_face_labels
branch
3 times, most recently
from
834b922 to
ae77eeb
Compare
imikejackson
force-pushed
the
topic/change_surface_nets_face_labels
branch
from
ae77eeb to
13212a1
Compare
JDuffeyBQ
approved these changes
Mar 7, 2025
Collaborator
JDuffeyBQ
left a comment
JDuffeyBQ
left a comment
There was a problem hiding this comment.
We'll just need an issue for revising the surface nets algorithm in the future.
Contributor
Author
imikejackson
force-pushed
the
topic/change_surface_nets_face_labels
branch
from
13212a1 to
b295611
Compare
…faceNets Also updated documentation with a short section about the face labels. Signed-off-by: Michael Jackson <[email protected]>
imikejackson
force-pushed
the
topic/change_surface_nets_face_labels
branch
from
b295611 to
bad4f82
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also updated documentation with a short section about the face labels.