Allow remapping blockstates and block properties via addons#759
Allow remapping blockstates and block properties via addons#759
Conversation
…ies and alter the blockstate id to resource mapping
|
@Doridian Hi, this would be my suggestion for implementing the resource-mapping. I moved the mapping out of the ResourcePools because it doesn't make sense for most resources to have this kind of mapping and creates further issues/confusion down the line in my opinion. The only thing i am still unsure about is, i don't really like looping over all pack-extensions each time What are your thought about this implementation? :) |
Yeah, we have to rely on addons not being silly with what they do in these calls. And also a cache should be possible here for Key -> Key maps, as those changing makes little sense, so once a single key has been mapped, it can be assumed that such mapping is "stable". And could be stored in a
The only possible downside I can see: If an addon uses But yeah, LGTM |
This PR is an alternative implementation of #754