Fix: Finally eliminate ajv error & Log url to user on deploy#76
Merged
Fix: Finally eliminate ajv error & Log url to user on deploy#76
Conversation
bh2smith
changed the title
bh2smith
changed the title
sainthiago
approved these changes
Feb 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We move the ajv dependencies out of dev deps. This actually resolves the issue.
running make-agent deploy without the [optional] url argument results in the following:
Digging into the code it seems that the env vars are not loaded. There is also no documentation about what env vars should be set if the URL is not supplied in the runtime argument.
Closes #77