Skip to content

Diffuse types#18

Open
rafaqz wants to merge 2 commits intomainfrom
diffuse_types
Open

Diffuse types#18
rafaqz wants to merge 2 commits intomainfrom
diffuse_types

Conversation

@rafaqz
Copy link
Copy Markdown
Member

@rafaqz rafaqz commented Mar 30, 2026

These are very important choses for model performance - scattered_uv totally dominates run time costs.

This PR makes it much more explicit which Diffuse UV model we are using.

It will break downstream packages like Microclimate.jl

@rafaqz rafaqz requested a review from mrke March 30, 2026 04:24
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 30, 2026

Codecov Report

❌ Patch coverage is 76.92308% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 93.45%. Comparing base (9d9d345) to head (3040356).

Files with missing lines Patch % Lines
src/solar_radiation.jl 75.67% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #18      +/-   ##
==========================================
+ Coverage   93.13%   93.45%   +0.32%     
==========================================
  Files           5        5              
  Lines         685      688       +3     
==========================================
+ Hits          638      643       +5     
+ Misses         47       45       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

diffuse_irradiance(diffuse_model, n, λτR, buffers, cz, intcz, Sλ_n, ar², m_Zₐ, albedo, z, FD, FDQ, s̄)

Calculate diffuse (scattered) spectral irradiance for a single wavelength.
Dispatches on `diffuse_model` to select the scattering algorithm.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

much better

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants