dags: Resize images that are too large for Bedrock#53
Merged
Conversation
awilfox
requested review from
anarchivist,
danschmidt5189,
jason-raitz and
yzhoubk
awilfox
force-pushed
the
awilfox/AP-672-resize-images
branch
from
489f0f7 to
7fa27f1
Compare
Member
Author
|
v2:
CI failure was due to Playwright OOM. |
jason-raitz
reviewed
Apr 23, 2026
jason-raitz
reviewed
Apr 23, 2026
jason-raitz
reviewed
Apr 23, 2026
jason-raitz
approved these changes
Apr 23, 2026
Contributor
jason-raitz
left a comment
jason-raitz
left a comment
There was a problem hiding this comment.
r+; Great Job! 
comments and suggestions are non-blocking and probably not necessary
anarchivist
reviewed
Apr 23, 2026
Member
anarchivist
left a comment
anarchivist
left a comment
There was a problem hiding this comment.
r+. i think there's some clean up on this, but i don't think it's blocking for the demo.
* Add `piffle` dep for IIIF metadata processing. * Add variable `TIND_IIIF_MANIFEST_URL_PATTERN` to define where the IIIF manifests live for the given TIND API. * Add helper code to the FetchTind class to fetch the image. This will likely be refactored to the TIND Client package later. * Add logic for determining the correct size. Implements: AP-672
awilfox
force-pushed
the
awilfox/AP-672-resize-images
branch
from
7fa27f1 to
1f91308
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
piffledep for IIIF metadata processing.Add variable
TIND_IIIF_MANIFEST_URL_PATTERNto define where the IIIF manifests live for the given TIND API.Add helper code to the FetchTind class to fetch the image. This will likely be refactored to the TIND Client package later.
Add logic for determining the correct size.
Implements: AP-672
If I had to do it over again, I'd make a helper class for all the faffing about, but that can be another fast-follow refactor.