AP-864: allow a temporary alert message on /location_requests/new - #59
Merged
Conversation
Co-authored-by: Codex GPT-5.6-sol <noreply@openai.com>
Contributor
|
Should we also disable the form submission if we're going to put the message up? The message displays and I see it's using the alert class but it doesn't stand out like it would in red or something. If I routinely ran these might skip over reading that. |
Member
Author
|
We could but I'm hoping we can get our rate limit lifted quickly. HathiTrust lookups aren't impacted so some submissions still work. |
Member
Author
|
Also, the |
danschmidt5189
approved these changes
Aug 27, 2026
danschmidt5189
left a comment
danschmidt5189
left a comment
Member
There was a problem hiding this comment.
Nit on the present? check, but besides that this looks good. I defer to you on that (though lean towards including it…).
davezuckerman
approved these changes
Aug 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will allow users of the Location Request tool to know that we're currently rate limited. The value is set using the
FRAMEWORK_LOCATION_REQUESTS_ALERTSenvironment variable.