Skip to content

AP-496: update build variables across the board #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
anarchivist merged 2 commits into from
Jan 8, 2026
Merged

AP-496: update build variables across the board #2

anarchivist merged 2 commits into from
Jan 8, 2026

Conversation

@anarchivist
Copy link
Member

@anarchivist anarchivist commented Jan 8, 2026 •
edited
Loading

i overlooked this when working on #1.

steve-sullivan
steve-sullivan approved these changes Jan 8, 2026
View reviewed changes
Copy link
Contributor

@steve-sullivan steve-sullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

awilfox
awilfox approved these changes Jan 8, 2026
View reviewed changes
Copy link
Member

@awilfox awilfox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. r+

@anarchivist anarchivist merged commit cf65c3f into main Jan 8, 2026
5 checks passed
@anarchivist anarchivist deleted the AP-496-update-build-variables branch January 8, 2026 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@awilfox awilfox awilfox approved these changes

@steve-sullivan steve-sullivan steve-sullivan approved these changes

@danschmidt5189 danschmidt5189 Awaiting requested review from danschmidt5189

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@anarchivist @awilfox @steve-sullivan