heimdall: Odin protocol version 4 support

[rtammekivi]

I investigated with Odin3 and wireshark to see the differences. Odin versions 3.12.xx sent version 3, and the newer ones send version 4. This is needed for S8/S8+ american variants it seems.

Heimdall thus far did not send version number at all.

[rtammekivi]

This is successfully tested with S6 and upwards, different models.

[TimoSairiala]

just a cosmetic thingy, but there is spelling mistake "verison" in the comment

[rtammekivi]

Right, I will update. Do you otherwise think this is ok or is there anything else to change?
Besides testing of course

[rtammekivi]

I updated the pull request, I'm not sure if I did it properly though.

[Benjamin-Dobell]

@Blefish Thanks for this.

Before I merge I'll have to find some time to dust off all my old Samsung devices (pre S6) and see how this affects them. Also have an S8 on hand so will test there as well.

[rtammekivi]

Sounds good to me, I would like to know if if actually fixes the problem for someone else as well, because this commit is from december and I used older Heimdall version to base this on originally.

[swedishjeff]

I'll bite. I'm seeing a successful (?) output from heimdall:

Initialising connection...
Detecting device...
Claiming interface...
Setting up interface...

Initialising protocol...
Protocol initialisation successful.

Beginning session...
Releasing device interface...

But I get the error "Odin protocol version error" on the S7 I'm working with.

If I can get the updated version for Linux (I don't know how to build from source) I'll give it a try.

[nvtkaszpir]

@swedishjeff about linux build, see Linux/README at the very end.

[fftmp]

This fix worked for me also. Why it doesn't accepted?

Percentage fix: fftmp-forked@04e8eb6

[ixonstater]

This fix worked for me as well on a Samsung S7.

[KTibow]

This fix doesn't work for me:

Heimdall v1.4.2

Copyright (c) 2010-2017 Benjamin Dobell, Glass Echidna
http://www.glassechidna.com.au/

This software is provided free of charge. Copying and redistribution is
encouraged.

If you appreciate this software and you would like to support future
development please consider donating:
http://www.glassechidna.com.au/donate/

Initialising connection...
Detecting device...
Claiming interface...
Setting up interface...

Initialising protocol...
ERROR: Protocol initialisation failed!

Releasing device interface...

With --no-reboot --resume, the pit it outputs is empty.