Context menu - #372
Conversation
|
Let me know when it's ready for review, I'll look into it for the next release. |
Is there a reason why you explicitly get the shortcut target file by using binary file reading? Please think about it if you're still working on this. |
|
Hi @Klocman, Life happened I couldn't work on this, and actually, I even forgot I worked on this. When I checked the So page you mentioned, I saw the comment which I used as a reference: https://stackoverflow.com/a/29749787/5910839 It is actually in the comments of Feel free to close, archive, edit or rewrite the PR. N.B: Sorry for the late response. |
|
Pls Update - Has this not yet been implemented? |
|
This was never a part of the road map but an optional thing. I implemented the basics yet it is far from perfect. If you like, you can try to compile and alpha-test my version so that we can fix the issues beforehand. |
|
C’mon! Please add this… All uninstallers can do it, but you can’t? It must be possible to locate a single program via right-click and perform its uninstallation along with removing leftover files. Why are you so strongly against it? |
|
@Dokukanal17tv, may I ask what convinced you that people owe you? |
|
Years later, with help of Claude, I found the problems and came up with another solution. I had to rebase as I was approx. 250 commits behind master. |
Klocman
left a comment
There was a problem hiding this comment.
Looks fine but needs some tweaking, I think.
- Please add an installer Task for the registry keys so that the user is able to choose if it should be enabled. The task should be unchecked by default.
- It should be safe to also look for the exe in
entry.GetSortedExecutables()to allow uninstalling of applications by their launch shortcut. - Since user clicks a menu item to uninstall, the expectation would be to see UI instead of console. Especially if there's an error the console will immediately close and not give any chance to see what happened.
|
Definitely. I'll work on it. |
Signed-off-by: Zafer Balkan <zafer@zaferbalkan.com>
eb69885 to
c6659d7
Compare
|
I hope it's okay this time. |
Signed-off-by: Zafer Balkan <zafer@zaferbalkan.com>
Signed-off-by: Zafer Balkan <zafer@zaferbalkan.com>
Signed-off-by: Zafer Balkan <zafer@zaferbalkan.com>
7f1233f to
58b6e3c
Compare
This is a work in progress.
The PR solves #331. It fulfills the minimum requirements. It is hard to test shell extensions.