Skip to content

Fix broker_discovery_path telemetry values to use lowercase; document Broker repo mirroring requirement#3041

Draft
Copilot wants to merge 2 commits into
sjain/add-telemetry-to-the-broker-discovery-flowfrom
copilot/sub-pr-3040
Draft

Fix broker_discovery_path telemetry values to use lowercase; document Broker repo mirroring requirement#3041
Copilot wants to merge 2 commits into
sjain/add-telemetry-to-the-broker-discovery-flowfrom
copilot/sub-pr-3040

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 20, 2026

PR #3040 added broker_discovery_path telemetry attributes to BrokerDiscoveryClient.kt, but the string values of the path constants were UPPERCASE ("ACCOUNT_MANAGER", "CACHE", "IPC", "ACCOUNT_MANAGER_FALLBACK") — inconsistent with the lowercase values documented in AttributeName.java's Javadoc and with the parent PR #3040 branch.

Changes

  • BrokerDiscoveryClient.kt: Fix path constant string values to lowercase to match the AttributeName.broker_discovery_path Javadoc and the parent branch:
    // Before (incorrect)
    const val ACCOUNT_MANAGER = "ACCOUNT_MANAGER"
    const val CACHE = "CACHE"
    const val IPC = "IPC"
    const val ACCOUNT_MANAGER_FALLBACK = "ACCOUNT_MANAGER_FALLBACK"
    
    // After (correct)
    const val ACCOUNT_MANAGER = "account_manager"
    const val CACHE = "cache"
    const val IPC = "ipc"
    const val ACCOUNT_MANAGER_FALLBACK = "account_manager_fallback"

Broker Repo Mirroring

Per the AttributeName.java header note, the following 7 attributes added in PR #3040 must be mirrored in the Broker repo's (AzureAD/ad-accounts-for-android) AttributeName enum in a coordinated PR:

  • is_installed_by_application_info
  • is_enabled_by_application_info
  • is_installed_by_package_info
  • is_enabled_by_enabled_setting
  • broker_discovery_installed_candidate_count
  • broker_discovery_reported_active_brokers
  • broker_discovery_path

📍 Connect Copilot coding agent with Jira, Azure Boards or Linear to delegate work to Copilot in one click without leaving your project management tool.

…Javadoc

Co-authored-by: siddhijain <30181294+siddhijain@users.noreply.github.com>
Copilot AI changed the title [WIP] [WIP] Address feedback on telemetry addition in Broker Discovery flow Fix broker_discovery_path telemetry values to use lowercase; document Broker repo mirroring requirement Mar 20, 2026
Copilot AI requested a review from siddhijain March 20, 2026 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants