Fix broker_discovery_path telemetry values to use lowercase; document Broker repo mirroring requirement#3041
Draft
Copilot wants to merge 2 commits into
Draft
Conversation
…Javadoc Co-authored-by: siddhijain <30181294+siddhijain@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] [WIP] Address feedback on telemetry addition in Broker Discovery flow
Fix broker_discovery_path telemetry values to use lowercase; document Broker repo mirroring requirement
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #3040 added
broker_discovery_pathtelemetry attributes toBrokerDiscoveryClient.kt, but the string values of the path constants were UPPERCASE ("ACCOUNT_MANAGER","CACHE","IPC","ACCOUNT_MANAGER_FALLBACK") — inconsistent with the lowercase values documented inAttributeName.java's Javadoc and with the parent PR #3040 branch.Changes
BrokerDiscoveryClient.kt: Fix path constant string values to lowercase to match theAttributeName.broker_discovery_pathJavadoc and the parent branch:Broker Repo Mirroring
Per the
AttributeName.javaheader note, the following 7 attributes added in PR #3040 must be mirrored in the Broker repo's (AzureAD/ad-accounts-for-android)AttributeNameenum in a coordinated PR:is_installed_by_application_infois_enabled_by_application_infois_installed_by_package_infois_enabled_by_enabled_settingbroker_discovery_installed_candidate_countbroker_discovery_reported_active_brokersbroker_discovery_path📍 Connect Copilot coding agent with Jira, Azure Boards or Linear to delegate work to Copilot in one click without leaving your project management tool.