Skip to content

[.github] Add workflow for build+test, fix eslint - #1234

Merged
Mike Harder (mikeharder) merged 12 commits into
developfrom
github-action-test
Apr 24, 2026
Merged

[.github] Add workflow for build+test, fix eslint#1234
Mike Harder (mikeharder) merged 12 commits into
developfrom
github-action-test

Conversation

@mikeharder

@mikeharder Mike Harder (mikeharder) commented Apr 24, 2026

Copy link
Copy Markdown
Member
  • enables faster iteration than ADO pipeline

Co-authored-by: Copilot <copilot@github.com>
@mikeharder Mike Harder (mikeharder) changed the title [.github] Add workflow for build+test [.github] Add workflow for build+test, fix eslint Apr 24, 2026
import * as assert from "assert";
import * as glob from "glob";
import * as path from "path";
import * as glob from "glob";

@mikeharder Mike Harder (mikeharder) Apr 24, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

linter error (imports must be sorted)

Comment thread package.json
"tsc": "tsc",
"lint": "eslint ./lib/**/*.ts ./test/**/*.ts ./*.ts",
"lint-fix": "eslint ./lib/**/*.ts ./test/**/*.ts ./*.ts --fix",
"lint": "DEBUG=eslint:eslint,eslint:linter eslint \"./lib/**/*.ts\" \"./test/**/*.ts\" \"./*.ts\"",

@mikeharder Mike Harder (mikeharder) Apr 24, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

increase verbosity, quote args to prevent shell expansion (files were being missed)

Comment thread lib/validate.ts
import * as path from "path";
import * as fs from "fs";
import jsYaml from "js-yaml";
import { dump as yamlDump } from "js-yaml";

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

narrow import to fix lint error

@mikeharder
Mike Harder (mikeharder) merged commit 873851b into develop Apr 24, 2026
7 checks passed
@mikeharder
Mike Harder (mikeharder) deleted the github-action-test branch April 24, 2026 22:45
@github-project-automation github-project-automation Bot moved this from 🤔 Triage to 🔬 Dev in PR in Azure SDK EngSys 🚀🌒🧑‍🚀 Apr 24, 2026
@kurtzeborn Scott K (kurtzeborn) moved this from 🔬 Dev in PR to 🎊 Closed in Azure SDK EngSys 🚀🌒🧑‍🚀 Apr 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

3 participants