-
Notifications
You must be signed in to change notification settings - Fork 3.2k
[AutoPR azure-mgmt-edgemarketplace]-generated-from-SDK Generation - Python-5751510 #44654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[AutoPR azure-mgmt-edgemarketplace]-generated-from-SDK Generation - Python-5751510 #44654
Conversation
…ace.Management/tspconfig.yaml', API Version: 2025-10-01-preview, SDK Release Type: beta, and CommitSHA: '06616874d9002bb259ca541be63272c3a4edafa8' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=5751510 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR introduces the initial beta release (1.0.0b1) of the Azure EdgeMarketplace Management SDK for Python, auto-generated from TypeSpec specifications. The SDK provides management capabilities for Azure Edge Marketplace services including operations, publishers, and offers.
Changes:
- New SDK package
azure-mgmt-edgemarketplacewith API version2025-10-01-preview - Client implementation with sync/async support for Operations, Offers, and Publishers
- Generated test stubs and sample code for all API operations
Reviewed changes
Copilot reviewed 51 out of 51 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| ci.yml | CI/CD pipeline configuration for the edgemarketplace SDK |
| tsp-location.yaml | TypeSpec source location and commit reference |
| pyproject.toml | Package metadata and build configuration |
| _version.py | Version identifier (1.0.0b1) |
| _client.py / aio/_client.py | Main client implementations (sync and async) |
| operations/_operations.py | Sync operation implementations for all resource types |
| aio/operations/_operations.py | Async operation implementations for all resource types |
| models/_models.py | Data models for API requests and responses |
| models/_enums.py | Enumeration types for API parameters |
| generated_tests/*.py | Auto-generated test stubs |
| generated_samples/*.py | Auto-generated sample code |
| CHANGELOG.md | Release notes for initial version |
| :ivar request_id: The name of the publisher. Required. | ||
| :vartype request_id: str | ||
| """ | ||
|
|
||
| request_id: str = rest_field(name="requestId", visibility=["read", "create", "update", "delete", "query"]) | ||
| """The name of the publisher. Required.""" |
Copilot
AI
Jan 16, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The documentation for request_id incorrectly states 'The name of the publisher'. Based on the class name AccessTokenReadRequest and the field name request_id, this should describe a request identifier for accessing tokens, not a publisher name.
| :ivar request_id: The name of the publisher. Required. | |
| :vartype request_id: str | |
| """ | |
| request_id: str = rest_field(name="requestId", visibility=["read", "create", "update", "delete", "query"]) | |
| """The name of the publisher. Required.""" | |
| :ivar request_id: The identifier of the access token read request. Required. | |
| :vartype request_id: str | |
| """ | |
| request_id: str = rest_field(name="requestId", visibility=["read", "create", "update", "delete", "query"]) | |
| """The identifier of the access token read request. Required.""" |
| :vartype publisher_name: str | ||
| :ivar edge_market_place_region: The region where the disk will be created. Required. | ||
| :vartype edge_market_place_region: str | ||
| :ivar ege_market_place_resource_id: The region where the disk will be created. |
Copilot
AI
Jan 16, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Corrected spelling of 'ege_market_place_resource_id' to 'edge_market_place_resource_id'
| :vartype publisher_name: str | ||
| :ivar edge_market_place_region: The region where the disk will be created. Required. | ||
| :vartype edge_market_place_region: str | ||
| :ivar ege_market_place_resource_id: The region where the disk will be created. |
Copilot
AI
Jan 16, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The documentation for ege_market_place_resource_id incorrectly states 'The region where the disk will be created', which is the same as edge_market_place_region on line 53. This field should describe a resource ID, not a region.
Configurations: 'specification/edgemarketplace/Microsoft.EdgeMarketPlace.Management/tspconfig.yaml', API Version: 2025-10-01-preview, SDK Release Type: beta, and CommitSHA: '06616874d9002bb259ca541be63272c3a4edafa8' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=5751510 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release. Release plan link: https://web.powerapps.com/apps/821ab569-ae60-420d-8264-d7b5d5ef734c?release-plan-id=cbfb86b0-12f1-f011-8407-000d3a5d2e0b Submitted by: [email protected]
Release Plan Details
Spec pull request: Edge Marketplace new 2025-10-01 preview API version azure-rest-api-specs#38124
Spec API version: 2025-10-01-preview