-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Pass is_reasoning_model through QAEvaluator #44640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Pass is_reasoning_model through QAEvaluator #44640
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request addresses issue #43842 by enabling the QAEvaluator to forward the is_reasoning_model parameter to its LLM-based sub-evaluators. This prevents max_tokens from being sent to reasoning models (o1/o3) which don't support that parameter.
Changes:
- Modified QAEvaluator to extract
is_reasoning_modelfrom kwargs and pass it to all LLM-based sub-evaluators (Groundedness, Relevance, Coherence, Fluency, Similarity) - Added comprehensive unit tests to verify the parameter is correctly propagated to sub-evaluators
- Added an unrelated change to set a default value for
image_tagin AzureOpenAIPythonGrader
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| sdk/evaluation/azure-ai-evaluation/azure/ai/evaluation/_evaluators/_qa/_qa.py | Extracts is_reasoning_model from kwargs and forwards it to all LLM-based sub-evaluators |
| sdk/evaluation/azure-ai-evaluation/tests/unittests/test_qa_evaluator.py | Adds unit tests verifying is_reasoning_model propagation to sub-evaluators |
| sdk/evaluation/azure-ai-evaluation/azure/ai/evaluation/_aoai/python_grader.py | Unrelated change: adds default value "2025-05-08" for image_tag parameter |
| sdk/evaluation/azure-ai-evaluation/tests/unittests/test_aoai_python_grader.py | Unrelated change: adds test for image_tag default value |
| pass_threshold: float, | ||
| source: str, | ||
| image_tag: Optional[str] = None, | ||
| image_tag: Optional[str] = "2025-05-08", |
Copilot
AI
Jan 13, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change appears unrelated to the main PR purpose of passing is_reasoning_model through QAEvaluator. The addition of a default value for image_tag should ideally be in a separate PR. Additionally, the default date "2025-05-08" appears to be in the past (current date is January 2026), which may indicate this is an outdated value or there's a version/tag naming convention that isn't immediately clear.
sdk/evaluation/azure-ai-evaluation/tests/unittests/test_aoai_python_grader.py
Outdated
Show resolved
Hide resolved
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
8b62a14 to
d3048ce
Compare
Fixes #43842
is_reasoning_modelto its LLM-based sub-evaluators (Groundedness/Relevance/Coherence/Fluency/Similarity), preventingmax_tokensfrom being sent to reasoning models.Tests:
python -m pytest sdk/evaluation/azure-ai-evaluation/tests/unittests/test_qa_evaluator.py -q