Test emit code #44639
Open
Test emit code #44639
+11,261
−6,587
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
howieleung
requested review from
dargilco,
glharper,
kingernupur,
nick863,
trangevi and
trrwilson
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This PR implements code generation updates for the Azure AI Projects SDK, including API model changes, type safety improvements, and security enhancements.
Changes:
- Replaced
eval()calls with explicit type conversions in serialization/deserialization logic for security - Introduced
PageOrderenum to replace string literals for pagination ordering - Added support for array encoding formats (pipe/comma/space/newline delimited) in model serialization
- Renamed multiple models and enums (e.g.,
ItemParam→Item,A2ATool→A2APreviewTool, various tool model renames) - Added deserialization caching mechanism for mutable types to ensure proper mutation handling
- Added numerous new enum types and model classes for new API features (ApplyPatch, FunctionShell, CustomTool, etc.)
Reviewed changes
Copilot reviewed 14 out of 15 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| azure/ai/projects/_utils/serialization.py | Replaced unsafe eval() calls with explicit type conversions (int/float/bool) for security |
| azure/ai/projects/_utils/model_base.py | Added array encoding support, deserialization caching for mutable types, and backcompat attribute handling |
| azure/ai/projects/_types.py | Added new type alias ComparisonFilterValueItems |
| azure/ai/projects/models/_enums.py | Large refactor: reordered enum values, added many new enum types (ApplyPatch*, FunctionShell*, CustomTool*, etc.), removed deprecated enums |
| azure/ai/projects/models/init.py | Extensive model renames and additions reflecting API changes |
| azure/ai/projects/operations/_operations.py | Updated type hints from Literal["asc", "desc"] to Union[str, PageOrder], renamed ItemParam to Item |
| azure/ai/projects/aio/operations/_operations.py | Same async version of operations changes |
| tests/finetuning/*.py | Added pylint suppressions for line-too-long |
| tests/agents/tools/test_agent_tools_with_conversations.py | Added pylint suppressions |
| tests/conftest.py | Added blank line (cosmetic) |
| samples/agents/tools/*.py | Added pylint suppressions |
| apiview-properties.json | Updated cross-language package mappings for renamed models |
| ): | ||
| # encoded string may be deserialized to sequence | ||
| return deserializer(obj) | ||
| except: # pylint: disable=bare-except |
There was a problem hiding this comment.
The use of a bare except clause is a security and maintainability concern. While pylint is disabled for this line, bare except clauses can catch system exceptions like SystemExit and KeyboardInterrupt, making it difficult to terminate the program. Consider catching specific exceptions instead, such as (TypeError, AttributeError, IndexError) which are likely the exceptions that could be raised when checking the deserializer structure.
Suggested change
| except: # pylint: disable=bare-except | |
| except (TypeError, AttributeError, IndexError): |
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
…erAuto in samples and tests
…extResponseFormatJsonSchema in samples and tests
… and adjust imports
…duce ContainerLogKind enum
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new API spec, a link to the pull request containing these API spec changes should be included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines