Skip to content

Replace ArmResourcePatchSync with ArmCustomPatchSync to fix JS SDK ge… #42834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
GokulPrasad-Work wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Replace ArmResourcePatchSync with ArmCustomPatchSync to fix JS SDK ge… #42834

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 12 additions & 34 deletions ...-manager/Microsoft.Monitor/Accounts/preview/2025-05-03-preview/azuremonitorworkspace.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3141,25 +3141,6 @@
"format": "uuid",
"description": "Universally Unique Identifier"
},
"Azure.ResourceManager.CommonTypes.TrackedResourceUpdate": {
"type": "object",
"title": "Tracked Resource",
"description": "The resource model definition for an Azure Resource Manager tracked top level resource which has 'tags' and a 'location'",
"properties": {
"tags": {
"type": "object",
"description": "Resource tags.",
"additionalProperties": {
"type": "string"
}
}
},
"allOf": [
{
"$ref": "../../../../../../common-types/resource-management/v6/types.json#/definitions/Resource"
}
]
},
"Azure.ResourceManager.ResourceProvisioningState": {
"type": "string",
"description": "The provisioning state of a resource type.",
Expand Down Expand Up @@ -3328,18 +3309,20 @@
},
"AzureMonitorWorkspaceResourceUpdate": {
"type": "object",
"description": "An Azure Monitor Workspace definition",
"description": "The type used for updating an Azure Monitor Workspace",
"properties": {
"tags": {
"type": "object",
"description": "Resource tags.",
"additionalProperties": {
"type": "string"
}
},
"properties": {
"$ref": "#/definitions/AzureMonitorWorkspace",
"description": "Resource properties"
}
},
"allOf": [
{
"$ref": "#/definitions/Azure.ResourceManager.CommonTypes.TrackedResourceUpdate"
}
]
}
},
"AzureMonitorWorkspaceSignalGroup": {
"type": "object",
Expand Down Expand Up @@ -4313,7 +4296,7 @@
},
"IssuePropertiesUpdate": {
"type": "object",
"description": "The issue properties",
"description": "The issue properties for update",
"properties": {
"title": {
"type": "string",
Expand Down Expand Up @@ -4372,18 +4355,13 @@
},
"IssueResourceUpdate": {
"type": "object",
"description": "The Issue resource",
"description": "The Issue resource update",
"properties": {
"properties": {
"$ref": "#/definitions/IssuePropertiesUpdate",
"description": "The resource-specific properties for this resource."
}
},
"allOf": [
{
"$ref": "../../../../../../common-types/resource-management/v6/types.json#/definitions/ProxyResource"
}
]
}
},
"ListParameter": {
"type": "object",
Expand Down
46 changes: 12 additions & 34 deletions ...-manager/Microsoft.Monitor/Accounts/preview/2025-10-03-preview/azuremonitorworkspace.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1390,25 +1390,6 @@
"format": "uuid",
"description": "Universally Unique Identifier"
},
"Azure.ResourceManager.CommonTypes.TrackedResourceUpdate": {
"type": "object",
"title": "Tracked Resource",
"description": "The resource model definition for an Azure Resource Manager tracked top level resource which has 'tags' and a 'location'",
"properties": {
"tags": {
"type": "object",
"description": "Resource tags.",
"additionalProperties": {
"type": "string"
}
}
},
"allOf": [
{
"$ref": "../../../../../../common-types/resource-management/v6/types.json#/definitions/Resource"
}
]
},
"Azure.ResourceManager.ResourceProvisioningState": {
"type": "string",
"description": "The provisioning state of a resource type.",
Expand Down Expand Up @@ -1565,18 +1546,20 @@
},
"AzureMonitorWorkspaceResourceUpdate": {
"type": "object",
"description": "An Azure Monitor Workspace definition",
"description": "The type used for updating an Azure Monitor Workspace",
"properties": {
"tags": {
"type": "object",
"description": "Resource tags.",
"additionalProperties": {
"type": "string"
}
},
"properties": {
"$ref": "#/definitions/AzureMonitorWorkspace",
"description": "Resource properties"
}
},
"allOf": [
{
"$ref": "#/definitions/Azure.ResourceManager.CommonTypes.TrackedResourceUpdate"
}
]
}
},
"Background": {
"type": "object",
Expand Down Expand Up @@ -1767,7 +1750,7 @@
},
"IssuePropertiesUpdate": {
"type": "object",
"description": "The issue properties",
"description": "The issue properties for update",
"properties": {
"title": {
"type": "string",
Expand Down Expand Up @@ -1830,18 +1813,13 @@
},
"IssueResourceUpdate": {
"type": "object",
"description": "The Issue resource",
"description": "The Issue resource update",
"properties": {
"properties": {
"$ref": "#/definitions/IssuePropertiesUpdate",
"description": "The resource-specific properties for this resource."
}
},
"allOf": [
{
"$ref": "../../../../../../common-types/resource-management/v6/types.json#/definitions/ProxyResource"
}
]
}
},
"ListParameter": {
"type": "object",
Expand Down
72 changes: 16 additions & 56 deletions .../resource-manager/Microsoft.Monitor/Accounts/stable/2025-10-03/azuremonitorworkspace.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1390,43 +1390,6 @@
"format": "uuid",
"description": "Universally Unique Identifier"
},
"Azure.ResourceManager.CommonTypes.ManagedServiceIdentityUpdate": {
"type": "object",
"description": "Managed service identity (system assigned and/or user assigned identities)",
"properties": {
"type": {
"$ref": "../../../../../../common-types/resource-management/v6/managedidentity.json#/definitions/ManagedServiceIdentityType",
"description": "The type of managed identity assigned to this resource."
},
"userAssignedIdentities": {
"type": "object",
"description": "The identities assigned to this resource by the user.",
"additionalProperties": {
"$ref": "../../../../../../common-types/resource-management/v6/managedidentity.json#/definitions/UserAssignedIdentity",
"x-nullable": true
}
}
}
},
"Azure.ResourceManager.CommonTypes.TrackedResourceUpdate": {
"type": "object",
"title": "Tracked Resource",
"description": "The resource model definition for an Azure Resource Manager tracked top level resource which has 'tags' and a 'location'",
"properties": {
"tags": {
"type": "object",
"description": "Resource tags.",
"additionalProperties": {
"type": "string"
}
}
},
"allOf": [
{
"$ref": "../../../../../../common-types/resource-management/v6/types.json#/definitions/Resource"
}
]
},
"Azure.ResourceManager.ResourceProvisioningState": {
"type": "string",
"description": "The provisioning state of a resource type.",
Expand Down Expand Up @@ -1587,22 +1550,24 @@
},
"AzureMonitorWorkspaceResourceUpdate": {
"type": "object",
"description": "An Azure Monitor Workspace definition",
"description": "The type used for updating an Azure Monitor Workspace",
"properties": {
"properties": {
"$ref": "#/definitions/AzureMonitorWorkspace",
"description": "Resource properties"
"tags": {
"type": "object",
"description": "Resource tags.",
"additionalProperties": {
"type": "string"
}
},
"identity": {
"$ref": "#/definitions/Azure.ResourceManager.CommonTypes.ManagedServiceIdentityUpdate",
"$ref": "../../../../../../common-types/resource-management/v6/managedidentity.json#/definitions/ManagedServiceIdentity",
"description": "The managed service identities assigned to this resource."
},
"properties": {
"$ref": "#/definitions/AzureMonitorWorkspace",
"description": "Resource properties"
}
},
"allOf": [
{
"$ref": "#/definitions/Azure.ResourceManager.CommonTypes.TrackedResourceUpdate"
}
]
}
},
"Background": {
"type": "object",
Expand Down Expand Up @@ -1821,7 +1786,7 @@
},
"IssuePropertiesUpdate": {
"type": "object",
"description": "The issue properties",
"description": "The issue properties for update",
"properties": {
"title": {
"type": "string",
Expand Down Expand Up @@ -1888,18 +1853,13 @@
},
"IssueResourceUpdate": {
"type": "object",
"description": "The Issue resource",
"description": "The Issue resource update",
"properties": {
"properties": {
"$ref": "#/definitions/IssuePropertiesUpdate",
"description": "The resource-specific properties for this resource."
}
},
"allOf": [
{
"$ref": "../../../../../../common-types/resource-management/v6/types.json#/definitions/ProxyResource"
}
]
}
},
"ListParameter": {
"type": "object",
Expand Down
4 changes: 2 additions & 2 deletions ...ingservice/resource-manager/Microsoft.Monitor/Accounts/typespec/AzureMonitorWorkspace.tsp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,9 @@ namespace Microsoft.Monitor {
/**
* Updates part of an Azure Monitor Workspace
*/
update is ArmResourcePatchSync<
update is ArmCustomPatchSync<
AzureMonitorWorkspaceResource,
AzureMonitorWorkspace
AzureMonitorWorkspaceResourceUpdate
>;

/**
Expand Down
2 changes: 1 addition & 1 deletion .../monitoringservice/resource-manager/Microsoft.Monitor/Accounts/typespec/issues/issues.tsp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ interface Issue {
>;

@doc("Update an issue")
update is ArmResourcePatchSync<IssueResource, IssueProperties>;
update is ArmCustomPatchSync<IssueResource, IssueResourceUpdate>;

@doc("Get issue properties")
get is ArmResourceRead<IssueResource>;
Expand Down
29 changes: 29 additions & 0 deletions .../monitoringservice/resource-manager/Microsoft.Monitor/Accounts/typespec/issues/models.tsp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -367,6 +367,35 @@ model RelatedResources {
value: RelatedResource[];
}

@doc("The issue properties for update")
model IssuePropertiesUpdate {
@doc("The issue title")
title?: string;

@doc("The issue status")
status?: Status;

@doc("The issue severity")
severity?: string;

@doc("The issue impact time (in UTC)")
impactTime?: utcDateTime;

@added(Versions.v2025_10_03)
@doc("The issue background information")
background?: Background;

@added(Versions.v2025_10_03_stable)
@doc("The issue notification settings")
notifications?: Notifications;
}

@doc("The Issue resource update")
model IssueResourceUpdate {
@doc("The resource-specific properties for this resource.")
properties?: IssuePropertiesUpdate;
}

@@clientName(ListParameter, "ListParameterContent", "csharp");
@doc("Parameters for listing related entities")
model ListParameter {
Expand Down
27 changes: 27 additions & 0 deletions ...ication/monitoringservice/resource-manager/Microsoft.Monitor/Accounts/typespec/models.tsp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,3 +148,30 @@ namespace Microsoft.Monitor {
@@TypeSpec.Versioning.added(Microsoft.Monitor.AzureMonitorWorkspaceResource.identity,
Microsoft.Monitor.Versions.v2025_10_03_stable
);

namespace Microsoft.Monitor {
/**
* The type used for updating an Azure Monitor Workspace
*/
model AzureMonitorWorkspaceResourceUpdate {
/**
* Resource tags.
*/
#suppress "@azure-tools/typespec-azure-resource-manager/arm-no-record" "tags is a standard ARM update pattern"
tags?: Record<string>;

/**
* The managed service identities assigned to this resource.
*/
identity?: Azure.ResourceManager.CommonTypes.ManagedServiceIdentity;

/**
* Resource properties
*/
properties?: AzureMonitorWorkspace;
}
}

@@TypeSpec.Versioning.added(Microsoft.Monitor.AzureMonitorWorkspaceResourceUpdate.identity,
Microsoft.Monitor.Versions.v2025_10_03_stable
);
Loading