Open
Conversation
…tart-templates into byod-triggerable-logic-app
…tart-templates into byod-triggerable-logic-app
UttejG
reviewed
Apr 6, 2026
UttejG
left a comment
UttejG
left a comment
There was a problem hiding this comment.
I see lot of references to Azure AD. If i am not wrong, most of these should be Entra ID. Other than that this looks fine to me.
application-workloads/identity-governance/byod-logic-app/azuredeploy.json
Show resolved
Hide resolved
application-workloads/identity-governance/byod-logic-app/azuredeploy.json
Show resolved
Hide resolved
| }, | ||
| "type": "Http", | ||
| "inputs": { | ||
| "uri": "https://graph.microsoft.com/beta/identityGovernance/catalogs/@{triggerBody()?['catalogId']}/accessPackageResources/@{triggerBody()?['customDataProvidedResourceId']}/uploadSessions", |
Comment on lines
+306
to
+327
| "status": { | ||
| "type": "string" | ||
| }, | ||
| "isUploadDone": { | ||
| "type": "boolean" | ||
| }, | ||
| "createdDateTime": { | ||
| "type": "string" | ||
| }, | ||
| "expirationDateTime": { | ||
| "type": "string" | ||
| }, | ||
| "stats": { | ||
| "type": "object", | ||
| "properties": { | ||
| "filesUploaded": { | ||
| "type": "integer" | ||
| }, | ||
| "totalBytesUploaded": { | ||
| "type": "integer" | ||
| } | ||
| } |
There was a problem hiding this comment.
I see that we are only using the id in the next step. Is it necessary to define these other properties?
UttejG
reviewed
Apr 8, 2026
Comment on lines
+29
to
+31
| "Public", | ||
| "USGovernment", | ||
| "China" |
There was a problem hiding this comment.
Jsut a FYI, az cli uses the following names
"AzureCloud"
"AzureChinaCloud"
"AzureUSGovernment"
Comment on lines
+214
to
+217
| "graphEndpoint": { | ||
| "type": "String", | ||
| "defaultValue": "https://graph.microsoft.com" | ||
| } |
There was a problem hiding this comment.
Shouldn't we be using variables('cloud').graph which means we don't need this param?
| }, | ||
| "type": "Http", | ||
| "inputs": { | ||
| "uri": "@{parameters('graphEndpoint')}/beta/identityGovernance/catalogs/@{triggerBody()?['catalogId']}/accessPackageResources/@{triggerBody()?['customDataProvidedResourceId']}/uploadSessions", |
There was a problem hiding this comment.
Should we not be using variables('cloud').graph ?
| }, | ||
| "authentication": { | ||
| "type": "ManagedServiceIdentity", | ||
| "audience": "@{parameters('graphEndpoint')}" |
UttejG
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Check these items before submitting a PR...
Contribution Guide
Best Practice Guide
Changelog