fix(iot-dev): Timeout stale CBS authentication#1848
Open
arnabnandy7 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
mainbranch.Reference/Link to the issue solved with this PR (if any)
Fixes #1802
Description of the problem
When an AMQP connection using SAS token authentication sent a CBS authentication message during proactive token renewal, the SDK scheduled the next renewal immediately but did not track whether the CBS authentication response was ever received.
If the CBS response was lost or never delivered, the client could continue to appear connected while telemetry stopped making progress and messages eventually expired. The only recovery path was an external reconnect, such as restarting the application.
Description of the solution
Added a CBS authentication response timeout to the AMQP SAS token renewal flow. After sending a CBS authentication message, the renewal handler now schedules a timeout based on the configured device operation timeout.
If a successful CBS authentication response arrives before the timeout, the timeout task is cancelled and normal link opening continues. If no response arrives before the timeout, the CBS session is treated as unhealthy and the existing connection recovery path is triggered.
Added unit tests covering both timeout notification and timeout cancellation when an authentication response is received.