{Compute} az vm diagnostics: Migrate command group to aaz-based implementation#32765
{Compute} az vm diagnostics: Migrate command group to aaz-based implementation#32765william051200 wants to merge 5 commits intoAzure:devfrom
az vm diagnostics: Migrate command group to aaz-based implementation#32765Conversation
william051200
requested review from
jsntcy,
wangzelin007,
yanzhudd and
zhoxing-ms
as code owners
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
bot
added
the
Compute
There was a problem hiding this comment.
Pull request overview
Migrates az vm diagnostics set from the mgmt.compute SDK-based implementation to an AAZ-based implementation, aligning this command group with ongoing AAZ migration work in the vm module.
Changes:
- Update
set_diagnostics_extensionto use AAZVMShowoutput (get_instance_view) and AAZvm extension deletewhen removing incompatible diagnostics extensions. - Switch extension instance-view parsing to dict/key-based access patterns.
- Remove the
compute_vm_sdkbinding from thevm diagnosticscommand group registration.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
src/azure-cli/azure/cli/command_modules/vm/custom.py |
Reworks set_diagnostics_extension to use AAZ VM show output + AAZ extension delete for incompatible versions. |
src/azure-cli/azure/cli/command_modules/vm/commands.py |
Registers vm diagnostics command group without the mgmt.compute SDK command type. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| poller = VmExtentionDelete(cmd.cli_ctx)(command_args={ | ||
| 'resource_group': resource_group_name, |
There was a problem hiding this comment.
AAZ command classes in this file are instantiated with the cli_ctx= keyword (e.g., EnableBootDiagnostics(cli_ctx=cmd.cli_ctx)). Here VmExtentionDelete(cmd.cli_ctx) passes cli_ctx positionally; please align with the established pattern to avoid breakage if the constructor signature changes and to keep the style consistent.
| no_auto_upgrade=False): | ||
| from .aaz.latest.vm.extension import Delete as VmExtentionDelete | ||
| vm = get_instance_view(cmd, resource_group_name, vm_name) | ||
| is_linux_os = _is_linux_os_by_aaz(vm) |
There was a problem hiding this comment.
get_instance_view returns an AAZ/VMShow result that uses camelCase keys (e.g., storageProfile, osProfile). _is_linux_os_by_aaz checks snake_case keys (storage_profile, os_profile), so this will mis-detect Linux VMs as Windows and select the wrong diagnostics extension. Use _is_linux_os_aaz(vm) here or convert the VM show result to snake_case before calling the helper.
| is_linux_os = _is_linux_os_by_aaz(vm) | |
| is_linux_os = _is_linux_os_aaz(vm) |
| from .aaz.latest.vm.extension import Delete as VmExtentionDelete | ||
| vm = get_instance_view(cmd, resource_group_name, vm_name) |
There was a problem hiding this comment.
Typo in the imported alias name VmExtentionDelete ("Extention" -> "Extension"). This makes the code harder to read/search and is inconsistent with the rest of the module naming.
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
4 participants
Related command
az vm diagnostics setDescription
Migration from mgmt.compute to aaz-based
Testing Guide
History Notes
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.