{Core} Fix infinite wait for typespec generated SDK #32687
Merged
+703
−19,563
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evelyn-ys
requested review from
bebound,
calvinhzy,
jiasli,
jsntcy,
kairu-ms,
necusjz and
zhoxing-ms
as code owners
️✔️AzureCLI-FullTest
|
|
Hi @evelyn-ys, |
️✔️AzureCLI-BreakingChangeTest
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
bot
added
Auto-Assign
Contributor
There was a problem hiding this comment.
Pull request overview
Updates Azure CLI wait logic to correctly extract provisioning state from TypeSpec-generated SDK models and prevent infinite waits (e.g., az xxx wait).
Changes:
- Switches wait provisioning-state extraction to use
azure.cli.core.util.todict(TypeSpec-aware) instead ofknack.util.todict.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
necusjz
approved these changes
Jan 22, 2026
calvinhzy
approved these changes
Jan 23, 2026
|
Hey guys, as the wait worked in the version 2.81.0, is it worth to consider a patch version with this fix? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
az xxx waitDescription
Fix #32656
After migrating to typespec generated SDKs, we should use new
todictfunction defined inazure.cli.core.utilinstead of oldknack.util. Here are some background PRs: #30339, #32419 (comment)This PR updates the
todictfunction we used for getting provisioning state info for allaz xxx waitcommands. With the oldtodict, we will get an empty{}for typespec generated SDK models so that no provisioning state returned which will cause infinite wait.Testing Guide
az keyvault wait -n $vaultName -g $rgName --createdHistory Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.