{Network} Add Virtual Network Appliance feature #32645
Open
+17,037
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
william051200
requested review from
kairu-ms,
necusjz and
wangzelin007
as code owners
️✔️AzureCLI-FullTest
|
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| network virtual-network-appliance | sub group network virtual-network-appliance added |
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adds support for Virtual Network Appliance (VNA) feature to Azure CLI, implementing CRUD operations for managing virtual network appliances.
Changes:
- Added
virtual-network-appliancecommand group with create, list, show, update, and delete operations - Implemented custom operations to handle bandwidth type conversion from string to integer
- Added comprehensive integration tests covering all VNA operations
Reviewed changes
Copilot reviewed 6 out of 12 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| test_network_commands.py | Added integration test class for VNA operations covering create, show, update, list, and delete scenarios |
| test_network_virtual_network_appliance.yaml | Test recording file with HTTP interactions for VNA integration tests |
| virtual_network_appliance.py | Custom operations layer handling bandwidth type conversions and update schema customization |
| commands.py | Registered VNA commands in the command table |
| init.py | AAZ module initialization for VNA command group |
| __cmd_group.py | Command group definition for VNA commands |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| self.check('type(components)', 'array') | ||
| ]) | ||
|
|
||
| class NetworkVirtualNetworKApplianceScenario(ScenarioTest): |
There was a problem hiding this comment.
Corrected spelling of 'NetworK' to 'Network' in the class name.
Suggested change
| class NetworkVirtualNetworKApplianceScenario(ScenarioTest): | |
| class NetworkVirtualNetworkApplianceScenario(ScenarioTest): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
az network virtual-network-appliance createaz network virtual-network-appliance listaz network virtual-network-appliance showaz network virtual-network-appliance updateaz network virtual-network-appliance deleteDescription
Resolve #32590
aaz Azure/aaz#921
Testing Guide
Create first VNA with tags
az network virtual-network-appliance create --tagsShow created VNA, validate tag value, subnet id, bandwidth
az network virtual-network-appliance showUpdate created VNA's tag value
az network virtual-network-appliance update --tagsList all created VNA
az network virtual-network-appliance listCreate second VNA for verification purpose later
az network virtual-network-appliance createDelete first VNA and make sure the list only have second VNA left
az network virtual-network-appliance deleteaz network virtual-network-appliance listHistory Notes
[Network]
az network virtual-network-appliance: Support Virtual Network Appliance featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.