[RDBMS] az postgres flexible-server private-endpoint-connection / private-link-resource / server-logs / virtual-endpoint list: Fix linter issue and not exposing IDs parameter on the list command#30551
Closed
mattboentoro wants to merge 1 commit intoAzure:devfrom
Closed
Conversation
…vate-link-resource / server-logs / virtual-endpoint list: Fix linter issue and not exposing IDs parameter on the list command
️✔️AzureCLI-FullTest
|
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| postgres flexible-server private-endpoint-connection list | cmd postgres flexible-server private-endpoint-connection list update parameter server_name: removed property id_part=name |
||
| postgres flexible-server private-link-resource list | cmd postgres flexible-server private-link-resource list update parameter server_name: removed property id_part=name |
||
| postgres flexible-server server-logs list | cmd postgres flexible-server server-logs list update parameter server_name: removed property id_part=name |
||
| postgres flexible-server virtual-endpoint list | cmd postgres flexible-server virtual-endpoint list update parameter server_name: removed property id_part=name |
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
|
Member
|
@evelyn-ys We saw this issue come up when linter check is done; is it considered a breaking change to fix? |
Member
|
@wangzelin007 @AllyW Do you have knowledge of |
Member
|
@nasc17 I don't suggest breaking changes. You can add linter exclusion rules instead |
Contributor
Author
|
ok, I'll abandon this PR, and try using the exclusion rules instead |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
Description
Fix linter issue and not exposing IDs parameter on the list command
Testing Guide
Local testing
History Notes
[RDBMS] BREAKING CHANGE:
az postgres flexible-server private-endpoint-connection / private-link-resource / server-logs / virtual-endpoint list: Fix linter issue and not exposing IDs parameter on the list commandThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.