-
Notifications
You must be signed in to change notification settings - Fork 20
aksd: harden App Insights telemetry to anonymous app-usage counts #626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
gambtho
wants to merge
14
commits into
Azure:headlamp-downstream
Choose a base branch
from
gambtho:aksd/telemetry-privacy-hardening
base: headlamp-downstream
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
7a62754
aksd: lock down App Insights SDK config and strip envelope tags
gambtho 7dfa366
aksd: test privacy telemetry initializer
gambtho d203cc3
aksd: allowlist telemetry event types in headlampEventSlice
gambtho 5a21a6b
aksd: test allowlist gating and data non-propagation
gambtho 1a355cf
aksd: replace trackException with minimal exception event
gambtho 0beba92
aksd: test ErrorBoundary exception telemetry
gambtho 6812353
aksd: update pluginLib snapshot for removed trackException export
gambtho 4ce1f71
aksd: extract privacyTelemetryInitializer to side-effect-free module
gambtho 4288a9e
aksd: hide allowlist behind isTelemetryEventAllowlisted predicate
gambtho d8a18c4
aksd: refresh storybook snapshots for emotion class-hash drift
gambtho 27627d5
aksd: register privacy telemetry initializer before loadAppInsights
gambtho 81d16e3
aksd: clarify allowlist immutability JSDoc
gambtho 96fffec
aksd: restore trackException as scrubbed deprecated wrapper
gambtho 1c28941
aksd: tighten telemetry doc comments to match implementation
gambtho File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
88 changes: 88 additions & 0 deletions
88
frontend/src/components/common/ErrorBoundary/ErrorBoundary.test.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,88 @@ | ||
| /* | ||
| * Copyright 2025 The Kubernetes Authors | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| import { render } from '@testing-library/react'; | ||
| import { Provider } from 'react-redux'; | ||
| import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest'; | ||
| import * as analytics from '../../../lib/analytics'; | ||
| import store from '../../../redux/stores/store'; | ||
| import ErrorBoundary from './ErrorBoundary'; | ||
|
|
||
| class CustomDomainError extends Error { | ||
| constructor(message: string) { | ||
| super(message); | ||
| this.name = 'CustomDomainError'; | ||
| } | ||
| } | ||
|
|
||
| function Boom({ error }: { error: Error }): JSX.Element { | ||
| throw error; | ||
| } | ||
|
|
||
| describe('ErrorBoundary telemetry', () => { | ||
| let trackEventSpy: ReturnType<typeof vi.spyOn>; | ||
| let consoleErrorSpy: ReturnType<typeof vi.spyOn>; | ||
|
|
||
| beforeEach(() => { | ||
| trackEventSpy = vi.spyOn(analytics, 'trackEvent').mockImplementation(() => {}); | ||
| // React logs caught errors via console.error in dev — silence to keep test output clean. | ||
| consoleErrorSpy = vi.spyOn(console, 'error').mockImplementation(() => {}); | ||
| }); | ||
|
|
||
| afterEach(() => { | ||
| trackEventSpy.mockRestore(); | ||
| consoleErrorSpy.mockRestore(); | ||
| }); | ||
|
|
||
| it('calls trackEvent with exception name and only error.name in properties', () => { | ||
| const err = new CustomDomainError( | ||
| "namespace 'payments' not found at https://example.test/api/v1/namespaces/payments" | ||
| ); | ||
|
|
||
| render( | ||
| <Provider store={store}> | ||
| <ErrorBoundary fallback={<div>fallback</div>}> | ||
| <Boom error={err} /> | ||
| </ErrorBoundary> | ||
| </Provider> | ||
| ); | ||
|
|
||
| expect(trackEventSpy).toHaveBeenCalledWith('exception', { errorName: 'CustomDomainError' }); | ||
|
|
||
| // No call shipped the message or stack. | ||
| for (const call of trackEventSpy.mock.calls) { | ||
| const [, properties] = call; | ||
| if (properties) { | ||
| for (const value of Object.values(properties)) { | ||
| expect(value).not.toContain('payments'); | ||
| expect(value).not.toContain('https://'); | ||
| } | ||
| } | ||
| } | ||
| }); | ||
|
|
||
| it('uses the default Error.name "Error" for plain errors', () => { | ||
| render( | ||
| <Provider store={store}> | ||
| <ErrorBoundary fallback={<div>fallback</div>}> | ||
| <Boom error={new Error('boom')} /> | ||
| </ErrorBoundary> | ||
| </Provider> | ||
| ); | ||
|
|
||
| expect(trackEventSpy).toHaveBeenCalledWith('exception', { errorName: 'Error' }); | ||
| }); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.