Refactor event handling and update view rendering in HelloWorld#9
Open
souzadavi wants to merge 4 commits intoAzuraCast:mainfrom
Open
Refactor event handling and update view rendering in HelloWorld#9souzadavi wants to merge 4 commits intoAzuraCast:mainfrom
souzadavi wants to merge 4 commits intoAzuraCast:mainfrom
Conversation
Updated event handling to use new class references and modified route naming.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the example AzuraCast plugin to improve compatibility and code quality, modernize dependencies, and streamline event handling and view rendering. The most important changes are grouped below:
Dependency and Compatibility Updates:
>=8.2) tocomposer.jsonto ensure compatibility with newer PHP features."require": {}block fromcomposer.jsonfor cleaner dependency management.Event Handling and Routing Improvements:
events.php:'example'to'ExamplePlugin'for consistency.HelloWorldcontroller directly and updating the route name to'example:index'.AllTheListenersto reduce noise in the example. [1] [2]Controller and View Rendering Enhancements:
HelloWorldcontroller:'example::hello_world'to'ExamplePlugin::hello_world'.Template Update:
hello_world.phtmlfrom'minimal'to'panel'for a more modern UI style.Fixes issue:
Fix issue #8