chore: assess number of eccvm rows before accumulation#21839
Open
iakovenkos wants to merge 14 commits intonextfrom
Open
chore: assess number of eccvm rows before accumulation#21839iakovenkos wants to merge 14 commits intonextfrom
iakovenkos wants to merge 14 commits intonextfrom
Conversation
| // Overflow — flush then transplant | ||
| if shared_queue.get_num_rows() + app_rows + KERNEL_ECCVM_ROWS > ECCVM_CAPACITY: | ||
| flush_goblin() | ||
| insert_flush_kernel() |
Contributor
There was a problem hiding this comment.
This is probably going to be some sort of boolean flags, right?
Contributor
Author
There was a problem hiding this comment.
yes, hopefully just raising flags
| @@ -0,0 +1,120 @@ | |||
| # Goblin Reset Design | |||
Contributor
There was a problem hiding this comment.
We're getting there 👍
Collaborator
Flakey Tests🤖 says: This CI run detected 2 tests that failed, but were tolerated due to a .test_patterns.yml entry. |
…c-packages into si/goblin-flush-infra
iakovenkos
requested review from
IlyasRidhuan,
fcarreiro and
jeanmon
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.