fix: database for default configuration not initializing properly - #1094
Closed
kosciolek wants to merge 1 commit into
Closed
fix: database for default configuration not initializing properly#1094kosciolek wants to merge 1 commit into
default configuration not initializing properly#1094kosciolek wants to merge 1 commit into
Conversation
Contributor
|
Thank you so much @kosciolek ! |
guillaume-chervet
force-pushed
the
main
branch
6 times, most recently
from
July 23, 2023 12:38
e635488 to
e04fb4b
Compare
guillaume-chervet
force-pushed
the
main
branch
from
October 25, 2023 18:11
12d8328 to
1b4bc07
Compare
guillaume-chervet
force-pushed
the
main
branch
from
November 17, 2023 16:22
0af446c to
bf19dd0
Compare
guillaume-chervet
force-pushed
the
main
branch
3 times, most recently
from
November 29, 2023 20:39
4d00d68 to
0cc3821
Compare
guillaume-chervet
force-pushed
the
main
branch
2 times, most recently
from
December 7, 2023 05:52
620a9d3 to
e386fa1
Compare
guillaume-chervet
force-pushed
the
main
branch
from
January 2, 2024 10:01
34329f1 to
6e63e9e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Databases for all configuration names are created here: https://github.com/AxaFrance/react-oidc/blob/3e535c94dc57d59956498bfa0ca9536106039bda/packages/react/service_worker/OidcServiceWorker.ts#L288
Before a database is created, there's a check whether it already exists: https://github.com/AxaFrance/react-oidc/blob/3e535c94dc57d59956498bfa0ca9536106039bda/packages/react/service_worker/OidcServiceWorker.ts#L282
But the
defaultdatabase exists since the start: https://github.com/AxaFrance/react-oidc/blob/3e535c94dc57d59956498bfa0ca9536106039bda/packages/react/service_worker/OidcServiceWorker.ts#L41Which means it won't get properly initialized, so if you do something like this in
TrustedDomains.js:the database for
defaultwon't show the access token anyway, since it's already initialized to hide the access token:https://github.com/AxaFrance/react-oidc/blob/3e535c94dc57d59956498bfa0ca9536106039bda/packages/react/service_worker/OidcServiceWorker.ts#L50
I'm not 100% sure that it won't break something else (it seems not to!), but perhaps a maintainer could take a look.