propagate keyDown events on macOS if they are not handled in Avalonia#20944
Open
RaoulSeifertEnscape wants to merge 3 commits intoAvaloniaUI:masterfrom
Open
propagate keyDown events on macOS if they are not handled in Avalonia#20944RaoulSeifertEnscape wants to merge 3 commits intoAvaloniaUI:masterfrom
RaoulSeifertEnscape wants to merge 3 commits intoAvaloniaUI:masterfrom
Conversation
|
You can test this PR using the following package version. |
Collaborator
|
Author
|
@cla-avalonia agree |
|
You can test this PR using the following package version. |
|
You can test this PR using the following package version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
This PR adds default keyDown event handling for keyDown events that were not handled in Avalonia.
What is the current behavior?
Currently all keyDown events are consumed and none are forwarded to the nextResponder.
What is the updated/expected behavior with this PR?
With these changes the keyDown events that were not handled in Avalonia will be passed along the responder chain
How was the solution implemented (if it's not obvious)?
Should be obvious, as only simple calls to `[super keyDown:event] where added under the condition that handleKeyDown returns false.
Fixed issues
Fixes #20943