Skip to content

Fetch Gridicons via SwiftPM#1714

Merged
mokagio merged 1 commit intotrunkfrom
ainfra-445-migrate-simplenote-ios-pods-to-swiftpm-gridicons
Jun 16, 2025
Merged

Fetch Gridicons via SwiftPM#1714
mokagio merged 1 commit intotrunkfrom
ainfra-445-migrate-simplenote-ios-pods-to-swiftpm-gridicons

Conversation

@mokagio
Copy link
Copy Markdown
Contributor

@mokagio mokagio commented Jun 13, 2025

Fix

See https://linear.app/a8c/issue/AINFRA-445 and previous PRs like #1713 .

Test

Run the app on Simulator or device and check either the magic link flow or the privacy screen as they are the only ones using Gridicons. Notice the icons are still there

image

Note

UI tests failing because of #1717

Review

Only one developer required to review these changes, but anyone can perform the review.

Release

These changes do not require release notes.

@wpmobilebot
Copy link
Copy Markdown
Collaborator

App Icon📲 You can test the changes from this Pull Request in Simplenote Prototype Build by scanning the QR code below to install the corresponding build.
App NameSimplenote Prototype Build
Build Number1289
VersionPR #1714
Bundle IDcom.codality.NotationalFlow.Alpha
Commit40f8106
Installation URL0ur5oikj8f55o
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@mokagio mokagio self-assigned this Jun 13, 2025
@mokagio mokagio added this to the Future milestone Jun 13, 2025
@mokagio mokagio added the tooling Related to anything that supports the building & maintaining of the project. label Jun 13, 2025
@mokagio mokagio marked this pull request as ready for review June 13, 2025 20:08
@mokagio mokagio requested a review from a team June 13, 2025 20:10
@mokagio mokagio merged commit 3c4416e into trunk Jun 16, 2025
11 of 13 checks passed
@mokagio mokagio deleted the ainfra-445-migrate-simplenote-ios-pods-to-swiftpm-gridicons branch June 16, 2025 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tooling Related to anything that supports the building & maintaining of the project.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants