feat: add frontend link rewriter to propagate brand parameter#77
Open
rbcorrales wants to merge 2 commits intotrunkfrom
Open
feat: add frontend link rewriter to propagate brand parameter#77rbcorrales wants to merge 2 commits intotrunkfrom
rbcorrales wants to merge 2 commits intotrunkfrom
Conversation
- Add `Link_Rewriter` class to enqueue a frontend script that rewrites internal links. - Add new `link-rewriter/index.js` script: - Detects current brand from URL (`?brand=brand-slug`). - Rewrites all internal anchor tags to include the brand parameter if not already present. - Skips external links and links that already have a brand parameter. - Register and enqueue the script via `Link_Rewriter::init()` in `Initializer`. - Update webpack config to bundle `linkRewriter` and provide WordPress externals. This helps preserve brand context through links as users navigate the site.
- Expose current page brand from the backend via `wp_localize_script` - Store and get the brand preference from the `np_preferred_brand` LS key - Lint JS
adekbadek
approved these changes
Jun 24, 2025
| return; | ||
| } | ||
|
|
||
| // Enqueue WordPress dependencies. |
Member
There was a problem hiding this comment.
Is this necessary, if these scripts are listed as dependencies in the call on line 37?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
Link_Rewriterclass to enqueue a frontend script that rewrites internal links.link-rewriter/index.jsscript:?brand=brand-slug).Link_Rewriter::init()inInitializer.linkRewriterand provide WordPress externals.This helps preserve brand context through links as users navigate the site.
How to test the changes in this Pull Request:
?brand=brand‑a(or a valid brand slug) to the URL.hrefattribute of these internal links is rewritten (i.e.?brand=brand‑ais appended).Other information: