Skip to content

Conversation

@sankalps0549
Copy link
Collaborator

Description

This PR introduces the integration tests for the PropertyEditor class.

Changes in this PR:

  • Introduced the test suite test_suite_property_editor
  • Added test_integration_property_editor.py
  • Updated pytest markers with property_editor
  • Added property_editor pytest marker to the test_unit_property_editor.py class

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

Please delete options that are not relevant.

  • I have read the CONTRIBUTING document
  • My code follows the style guidelines of this project
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have updated the documentation accordingly
  • I have added a note to CHANGELOG.md describing my changes
  • My changes generate no new warnings
  • Any dependent changes have been merged and published

Data Generation

python run.py generate-baseline-data property_editor
image

Testing

Added Integration Tests for the PropertyEditor class

python run.py test -m property_editor
image

Additional Notes

N/A

@sankalps0549 sankalps0549 requested a review from Copilot December 15, 2025 19:25
@sankalps0549 sankalps0549 self-assigned this Dec 15, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds comprehensive integration tests for the PropertyEditor class in the moldflow-api module, including test infrastructure for property creation, manipulation, and validation.

Key Changes:

  • Added integration test suite with 11 test methods covering PropertyEditor functionality
  • Implemented baseline data generation script for test validation
  • Created test constants and configuration for property editor testing

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
tests/api/integration_tests/test_suite_property_editor/test_integration_property_editor.py Main test file with 11 integration tests covering PropertyEditor operations
tests/api/integration_tests/test_suite_property_editor/generate_expected_data_property_editor.py Data generation script for creating baseline test data
tests/api/integration_tests/test_suite_property_editor/data.json Baseline test data for validating PropertyEditor behavior
tests/api/integration_tests/test_suite_property_editor/constants.py Test configuration constants for property types and IDs
tests/api/integration_tests/metadata.json Updated metadata with property_editor test suite information
pytest.ini Added property_editor pytest marker

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@sankalps0549 sankalps0549 requested a review from Copilot December 15, 2025 19:29
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will merge latest feature/integration-tests into this.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed

@miraladsk miraladsk merged commit 84d4eac into feature/integration-tests Dec 17, 2025
19 checks passed
@sankalps0549 sankalps0549 deleted the property-editor-tests branch December 21, 2025 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants