-
Notifications
You must be signed in to change notification settings - Fork 1
PropertyEditor Integration Tests #56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds comprehensive integration tests for the PropertyEditor class in the moldflow-api module, including test infrastructure for property creation, manipulation, and validation.
Key Changes:
- Added integration test suite with 11 test methods covering PropertyEditor functionality
- Implemented baseline data generation script for test validation
- Created test constants and configuration for property editor testing
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/api/integration_tests/test_suite_property_editor/test_integration_property_editor.py | Main test file with 11 integration tests covering PropertyEditor operations |
| tests/api/integration_tests/test_suite_property_editor/generate_expected_data_property_editor.py | Data generation script for creating baseline test data |
| tests/api/integration_tests/test_suite_property_editor/data.json | Baseline test data for validating PropertyEditor behavior |
| tests/api/integration_tests/test_suite_property_editor/constants.py | Test configuration constants for property types and IDs |
| tests/api/integration_tests/metadata.json | Updated metadata with property_editor test suite information |
| pytest.ini | Added property_editor pytest marker |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
tests/api/integration_tests/test_suite_property_editor/test_integration_property_editor.py
Outdated
Show resolved
Hide resolved
tests/api/integration_tests/test_suite_property_editor/test_integration_property_editor.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will merge latest feature/integration-tests into this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed
…property-editor-tests
Description
This PR introduces the integration tests for the
PropertyEditorclass.Changes in this PR:
test_suite_property_editortest_integration_property_editor.pyproperty_editorproperty_editorpytest marker to thetest_unit_property_editor.pyclassType of change
Please delete options that are not relevant.
Checklist
Please delete options that are not relevant.
Data Generation
Testing
Added Integration Tests for the PropertyEditor class
Additional Notes
N/A