Skip to content

refactor: clarify callback responsibility and remove redundant topic cleanup logic - #3542

Open
BackendArchitectX wants to merge 1 commit into
AutoMQ:mainfrom
BackendArchitectX:BackendArchitectX/refactor-2721-callback-cleanup
Open

refactor: clarify callback responsibility and remove redundant topic cleanup logic#3542
BackendArchitectX wants to merge 1 commit into
AutoMQ:mainfrom
BackendArchitectX:BackendArchitectX/refactor-2721-callback-cleanup

Conversation

@BackendArchitectX

Copy link
Copy Markdown
Contributor

What changed

  • Remove the redundant deleted-topic traversal from ElasticReplicaManager#asyncApplyDelta.
  • Preserve callbacks for actual local partition deletion and partition state transitions.
  • Document the callback's immediate per-partition notification responsibility.

Why

Global deleted-topic cleanup is already handled by BrokerMetadataPublisher#notifyGroupCoordinatorOfDeletedPartitions after asyncApplyDelta completes. The additional deletedTopicIds() traversal in ElasticReplicaManager therefore caused redundant cleanup notifications.

Fixes #2721

Testing

  • :core:compileScala — passed
  • :core:S3UnitTest --tests unit.kafka.server.streamaspect.ElasticReplicaManagerTest — passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

refactor: clarify callback responsibility and remove redundant topic cleanup logic

1 participant