Skip to content
This repository was archived by the owner on Mar 5, 2018. It is now read-only.

Input group style and examples#461

Open
DJMyles wants to merge 1 commit into
AusDTO:developfrom
DJMyles:feature/input-group
Open

Input group style and examples#461
DJMyles wants to merge 1 commit into
AusDTO:developfrom
DJMyles:feature/input-group

Conversation

@DJMyles
Copy link
Copy Markdown
Contributor

@DJMyles DJMyles commented Jan 11, 2017

Description

a pattern which makes it easy for designers, developers and publishers to construct input / button combination structures across their site.

Additional information

  • single class in surrounding container
  • default button to the right
  • reverse class for button to the left
  • removes margining and appropriate border

Seeks to address - #460

screen shot 2017-01-11 at 3 03 38 pm

Definition of Done

@gazhands
Copy link
Copy Markdown

Be good to get everyones thoughts on site search using this kind of patten?
search

@gazhands
Copy link
Copy Markdown

Bit more flexible on mobile

@AndrewArch
Copy link
Copy Markdown

AndrewArch commented Jan 13, 2017

@gazhands - with the label moved into the Search text box via CSS and then moved off-screen when the box gets focus?

NB. I don't like 'reverse class for button to the left' - seems counter-intuitive to have the action (search/submit) before you've put your search terms in

@gazhands
Copy link
Copy Markdown

@gazhands
Copy link
Copy Markdown

@AndrewArch
Copy link
Copy Markdown

AndrewArch commented Jan 13, 2017

'Search' inside the text box shouldn't be a hint or place-holder text, it should be a label - like on dta.gov.au

image

See also #432

@lreichelt
Copy link
Copy Markdown

@gazhands on that design patterns hackpad... interesting that the empty searches were reduced but I'd love to know whether the number of 'search' searches increased... (what would happen if you just hit the button and no search term? would it register as empty or search I wonder?)

@Podgkin
Copy link
Copy Markdown

Podgkin commented Jan 16, 2017

Using an icon instead of text is always taking a gamble on your user's level of familiarity with the meaning of that symbol within the context of your system. The search icon is perhaps the most universal of web interface icons, however a magnifying glass does not provide inherent affordance, so the icon only approach can still be problematic for users with very low technological literacy.

Standardising to the icon approach will work on mobile sites sought out by people who regularly use the web. However, It may cause some issues for users who do not usually use technology but are required by government to use a site. This cohort is actually very large, and is over represented in some service oriented departments.

Using the icon is a sane default, but it may not be appropriate at all breakpoints for all sites. The system proposed by DJMyles allows text as well as an icon, which seems like a good solution.

As for the label, I would suggest adaptive labels

@gazhands
Copy link
Copy Markdown

@Podgkin Agree and we do already cover labels and hint text here http://guides.service.gov.au/design-guide/components/forms-buttons/index.html#hint-text

@gazhands
Copy link
Copy Markdown

And yes would like to test text as well as an icon for different breakpoints

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants