Refactor duplicated UI infrastructure - #755
Open
KillariDev wants to merge 11 commits into
Open
Conversation
…to t3code/review-ui-shared-code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The three UIs had accumulated parallel implementations of the same infrastructure and several very large workflow files. The duplicated ownership paths made fixes easy to apply in one app but miss in another, while the oversized components mixed domain derivation, transaction orchestration, and rendering. This refactor gives shared behavior one owner and separates app-specific workflows along cohesive boundaries without intentionally changing their appearance or behavior.
Validation
bun run tscbun run ensure-contract-artifacts && bun run check:shared-dependencies && bun run test:run -- --bail=1— 3,238 passed, 16 expected remote Uniswap skips, 0 failed across 320 filesbun run format:checkbun run checkbun run check:changedbun run knip, including production Trading entrypoint analysisbun run check:generated-cleangit diff --checkandgit diff origin/main...HEAD --checkorigin/mainPublished documentation was unchanged, so the documentation reviewer was not applicable. The full repository check still validated documentation freshness and structure.
Screenshots
Zoltar — deployed universe
Statoblast — seeded security pool
Trading — populated Markets