Skip to content

feat(contest-table): add AojIcpcRegionalProvider for ICPC Asia Regional#3683

Merged
KATO-Hiro merged 3 commits into
stagingfrom
#3680
Jun 17, 2026
Merged

feat(contest-table): add AojIcpcRegionalProvider for ICPC Asia Regional#3683
KATO-Hiro merged 3 commits into
stagingfrom
#3680

Conversation

@KATO-Hiro

@KATO-Hiro KATO-Hiro commented Jun 17, 2026

Copy link
Copy Markdown
Collaborator

close #3680

Summary by CodeRabbit

リリースノート

  • 新機能

    • ICPC地区予選(1998年~2024年)のコンテストデータを追加しました。これにより、27年分のICPC地区予選問題が利用可能になります。
  • 改善

    • ICPC関連のタイトル表示とラベル割り当てロジックを統一・最適化しました。
  • テスト

    • ICPC地区予選を含むコンテストテーブル機能の包括的なテストを追加・拡張しました。

KATO-Hiro and others added 3 commits June 17, 2026 05:53
…al (Phase 1-4)

- Rename ICPC_PRELIM_LABEL_OVERRIDES → ICPC_LABEL_OVERRIDES (shared by Prelim/Regional)
- Extract shared helpers to aoj_icpc_labels.ts: sortAojIcpcHeaderIds, AOJ_ICPC_TITLE_STYLE, buildAojIcpcDisplayConfig
- Add AojIcpcRegionalProvider (ICPCRegional1998–2024, 27 years)
- Register aojIcpcRegional preset in contestTableProviderGroups (inserted after aojIcpcPrelim)
- Add ICPCRegional task seed data (prisma/tasks.ts, 1998–2024)
- Add plan doc for ICPC 地区予選 table (issue #3680)

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…l and shared helpers

- Add Regional-specific test cases for formatAojIcpcTitle and buildAojIcpcLetterMap
- Add tests for sortAojIcpcHeaderIds and buildAojIcpcDisplayConfig shared helpers
- Reorganize describe blocks by Prelim/Regional/shared for clarity

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…3680)

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@KATO-Hiro

Copy link
Copy Markdown
Collaborator Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@KATO-Hiro, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 33 minutes and 22 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, the refill rate gradually slows as usage increases. The highest same-day bursts are limited more strictly.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 7e4bb163-f99a-49ca-92fc-15043e566751

📥 Commits

Reviewing files that changed from the base of the PR and between 6a4a881 and b20520e.

📒 Files selected for processing (7)
  • prisma/tasks.ts
  • src/features/tasks/utils/contest-table/aoj_icpc_labels.test.ts
  • src/features/tasks/utils/contest-table/aoj_icpc_labels.ts
  • src/features/tasks/utils/contest-table/aoj_icpc_providers.test.ts
  • src/features/tasks/utils/contest-table/aoj_icpc_providers.ts
  • src/features/tasks/utils/contest-table/contest_table_provider_groups.test.ts
  • src/features/tasks/utils/contest-table/contest_table_provider_groups.ts
📝 Walkthrough

Walkthrough

ICPCRegional1998〜2024のタスクデータ(約1862行)をprismaに追加し、ICPC_PRELIM_LABEL_OVERRIDESICPC_LABEL_OVERRIDESへ統一。sortAojIcpcHeaderIdsbuildAojIcpcDisplayConfigAOJ_ICPC_TITLE_STYLEを新規エクスポートし、AojIcpcRegionalProviderを実装してプリセット登録した。

Changes

ICPC地区予選テーブル追加

Layer / File(s) Summary
ICPCRegionalタスクデータ追加
prisma/tasks.ts
ICPCRegional1998〜2024の問題エントリ(problem_index 1200〜1466)をtasks配列へ追加。既存の型シグネチャは変更なし。
aoj_icpc_labels共通ヘルパー・定数のリファクタリング
src/features/tasks/utils/contest-table/aoj_icpc_labels.ts
ICPC_PRELIM_LABEL_OVERRIDESICPC_LABEL_OVERRIDESに統一。AOJ_ICPC_TITLE_STYLEsortAojIcpcHeaderIdsbuildAojIcpcDisplayConfigを新規エクスポート。
Prelim/Regional両プロバイダの共通化
src/features/tasks/utils/contest-table/aoj_icpc_providers.ts
AojIcpcPrelimProvidergetHeaderIdsForTask等を共通ヘルパーへ置換。AojIcpcRegionalProviderも同様に共通化しgetContestRoundLabelをリージョン版に設定。
AojIcpcRegionalプリセット登録
src/features/tasks/utils/contest-table/contest_table_provider_groups.ts
ICPC_REGIONAL_OLDEST_YEAR/LATEST_YEAR定数追加、AojIcpcRegionalプリセット追加、contestTableProviderGroupsaojIcpcRegional公開。
ラベル・プロバイダ・グループのテスト整備
src/features/tasks/utils/contest-table/aoj_icpc_labels.test.ts, src/features/tasks/utils/contest-table/aoj_icpc_providers.test.ts, src/features/tasks/utils/contest-table/contest_table_provider_groups.test.ts
ICPC_LABEL_OVERRIDES参照に更新、AojIcpcRegionalProvider全メソッド・年境界・override経路の網羅テスト追加、プリセット型検証追加。

推定コードレビュー工数

🎯 3 (Moderate) | ⏱️ ~25 minutes

関連PR

🗺️ 地区を巡る旅、1998から2024へ
Regional の問題たち、ついに舞台へ
A・B・C… レターが踊る、12問並んで
Override でも迷わず、正しい道を歩む
ICPC の地図、これにて完成 🏆

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch #3680

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@KATO-Hiro KATO-Hiro left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KATO-Hiro KATO-Hiro merged commit 0279038 into staging Jun 17, 2026
3 checks passed
@KATO-Hiro KATO-Hiro deleted the #3680 branch June 17, 2026 08:44
@coderabbitai

coderabbitai Bot commented Jun 17, 2026

Copy link
Copy Markdown
Contributor
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[feat] テーブル「ICPC 地区予選」を追加しましょう

1 participant