Open
Conversation
not in sphinx cache so no need
peterbarker
reviewed
Apr 25, 2026
| # debug(" FILE: %s" % file) | ||
| source_file_path = os.path.join(root, file) | ||
| source_file = open(source_file_path, 'r', encoding='utf-8') | ||
| source_file = open(file_path, 'r', encoding='utf-8') |
Contributor
There was a problem hiding this comment.
pathlib would be nice here
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some slight cleanup on the common copy file :
remove useless exception : if filecmp.cmp it would be from a filesystem issue so the following write on will also raise an error, therefore that is useless so we can simplify
unifiy the variables names as they are all the same
For the useralert.js, we don't need clever directive, just copying to the vehicle _static directory is enough
Correct the default vehicle copy list by adding antennatracker and blimp