Skip to content

Terrain loading#7690

Open
timtuxworth wants to merge 1 commit intoArduPilot:masterfrom
timtuxworth:terrain_loading
Open

Terrain loading#7690
timtuxworth wants to merge 1 commit intoArduPilot:masterfrom
timtuxworth:terrain_loading

Conversation

@timtuxworth
Copy link
Copy Markdown
Contributor

@timtuxworth timtuxworth commented Apr 21, 2026

Based on this issue from the 4.7 beta testing, some clarifications/updates of the guidance about using the terrain functions in ardupilot. ArduPilot/ardupilot#32773 (comment)

Also updated with new information about terrain support in QGroundControl and SiYi's UniGCS.

Here's my suggestions.

@Hwurzburg Hwurzburg requested a review from tridge April 21, 2026 21:35
@timtuxworth timtuxworth force-pushed the terrain_loading branch 3 times, most recently from 2bff00e to bf0eb7b Compare April 21, 2026 22:04
Comment thread common/source/docs/common-terrain-following.rst Outdated
Comment thread common/source/docs/common-terrain-following.rst Outdated
Comment thread common/source/docs/common-terrain-following.rst Outdated
Comment thread common/source/docs/common-terrain-following.rst Outdated
Comment thread common/source/docs/common-terrain-following.rst Outdated
Comment thread common/source/docs/common-terrain-following.rst Outdated
@rmackay9
Copy link
Copy Markdown
Contributor

This isn't my page so these are just suggestions.

@timtuxworth
Copy link
Copy Markdown
Contributor Author

I'm getting this. What does it mean? Cache restored from key: pre-commit-3|/opt/hostedtoolcache/Python/3.10.20/x64|7ebd9e6d3cefb5a9c1ac0b9397469f9592d5f13999e982cb9f850145750ec611
Run pre-commit run --show-diff-on-failure --color=always --all-files
pre-commit run --show-diff-on-failure --color=always --all-files
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
env:
TEST: 1
pythonLocation: /opt/hostedtoolcache/Python/3.10.20/x64
PKG_CONFIG_PATH: /opt/hostedtoolcache/Python/3.10.20/x64/lib/pkgconfig
Python_ROOT_DIR: /opt/hostedtoolcache/Python/3.10.20/x64
Python2_ROOT_DIR: /opt/hostedtoolcache/Python/3.10.20/x64
Python3_ROOT_DIR: /opt/hostedtoolcache/Python/3.10.20/x64
LD_LIBRARY_PATH: /opt/hostedtoolcache/Python/3.10.20/x64/lib
codespell................................................................Failed

  • hook id: codespell
  • exit code: 65

@Hwurzburg
Copy link
Copy Markdown
Contributor

@timtuxworth failing spelling check for ALSO

@timtuxworth
Copy link
Copy Markdown
Contributor Author

@timtuxworth failing spelling check for ALSO

Thanks @Hwurzburg . Actually 'ALOS' is an acronym so it is correct. I've scattered in a few # codespell:ignore alos, but is there a way to establish a dictionary for this kind of thing?

rmackay9
rmackay9 previously approved these changes Apr 23, 2026
@rmackay9
Copy link
Copy Markdown
Contributor

there's some repetition but overall this is a big improvement, nicely done!

@timtuxworth
Copy link
Copy Markdown
Contributor Author

I'm thinking @tridge will have some suggestions for improvement, what do you think Tridge?

@Ryanf55
Copy link
Copy Markdown
Contributor

Ryanf55 commented Apr 24, 2026

@timtuxworth failing spelling check for ALSO

Thanks @Hwurzburg . Actually 'ALOS' is an acronym so it is correct. I've scattered in a few # codespell:ignore alos, but is there a way to establish a dictionary for this kind of thing?

Yes, we can add a .codespellrc

Like so: https://github.com/containers/common/blob/main/.codespellrc

@timtuxworth
Copy link
Copy Markdown
Contributor Author

there's some repetition but overall this is a big improvement, nicely done!

I took this as a challenge, so I've tried to remove some of the duplication, which does mean I've moved a bunch of things around. This might mean you might want to look at it again @rmackay9 .

@timtuxworth
Copy link
Copy Markdown
Contributor Author

There is an existing note about autolandings here @Hwurzburg - I'm wondering if it needs to be updated to correctly describe AUTOLAND mode?

.. note:: in AUTO mode autolandings, the :ref:TERRAIN_FOLLOW<TERRAIN_FOLLOW> parameter
does have an impact, when a rangefinder is also used. See :ref:rangefinder-autolanding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants