chore: Update directory watcher and tell ProGuard to leave it alone#87
chore: Update directory watcher and tell ProGuard to leave it alone#87Rover656 wants to merge 2 commits intoAppliedEnergistics:mainfrom
Conversation
| -keepclassmembers class guideme.internal.hooks.mixins.* { | ||
| *; | ||
| } | ||
|
|
There was a problem hiding this comment.
Can you add a comment that it's because jni has a direct reference? (That's why, right?)
There was a problem hiding this comment.
Do we need to keep all? How much bigger does this make the resulting jar?
There was a problem hiding this comment.
Will look at how much can be stripped before it breaks, and document it's presence :)
There was a problem hiding this comment.
File size difference after changing to only preserving the JNI package (which still fixes the root issue)
Before: 5,192,460 bytes (5.2 MB on disk)
After: 5,195,286 bytes (5.2 MB on disk)
There was a problem hiding this comment.
So only preserving the JNI package made the jar larger?
There was a problem hiding this comment.
Sorry, before is a compilation of main. After is this branch after changes made. I neglected to compare before making this change
…oGuard I attempted just constructors, but further funky errors were caused as a result - seems safest to just prevent the JNI package from being trimmed
3 participants
Fixes MacOS directory watcher by ensuring ProGuard doesn't strip constructors used by JNI.
Also bumps the version of directory watcher as it also has MacOS JNI improvements.