Preserve NBT data for uninitialized ManagedGridNodes - #8782
Open
Mqrius wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the world is loaded,
ManagedGridNodes.loadFromNBT(tag)gets called and NBT data gets stored ininitDatabecause there is no actual Node yet to save it to. Later oncreateNode(initData)is called and loads the data fully.The problem is that before
createNodeis actually called minecraft triggers another saveToNBT. (I believe this happens when it promotes the proto-chunks to full chunks during world load)Currently that save cycle does not include the data in initData, so it gets lost when afterwards another loadFromNBT happens.
This PR saves the initData to the CompoundTag if there is no node but there is initData. (initData is wiped upon initialization, so this is safe)
--
I noticed this bug because SpatialIOPortBlockEntity objects would forget their owningPlayerId when logging out and back in, but it likely affects other data as well.