Do not log every single connect in a DDOS#11633
Draft
BalaM314 wants to merge 1 commit intoAnuken:masterfrom
Draft
Do not log every single connect in a DDOS#11633BalaM314 wants to merge 1 commit intoAnuken:masterfrom
BalaM314 wants to merge 1 commit intoAnuken:masterfrom
Conversation
Contributor
|
mmm yes but this helps to know when your server(s) is being raided. |
Contributor
|
maybe better to suppress them when there are more than 10 messages in one minute |
|
I don't think straight up removing it is a good idea |
Contributor
Author
this is a good idea |
Contributor
|
Maybe lower the log level of those to debug. Because no log at all is just worse... |
Contributor
|
Perhaps it could aggregate once every minute. |
Contributor
|
Yes but this need to cache a Ratekeeper, so it also need another thing to clean up this cache. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This log message was added in #10904. It is useful to help players who are falsely dosblacklisted, but it is not worth the massive amounts of console spam (and possibly lag) that it causes in a real DDoS attack.