Schema Mount support + actions support#73
Conversation
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
bartoszm
left a comment
bartoszm
left a comment
There was a problem hiding this comment.
Review of schema-mount + actions support. Overall solid feature addition — the reflection fallback chain is pragmatic given ODL's sealed APIs, and the module-level mounting is a nice extension. Nine observations below, including one correctness issue with action path placement.
(Ignore the three 'test' reviews above — those were debug artifacts.)
…A_MOUNT_SUPPORT # Conflicts: # cli/src/main/java/com/mrv/yangtools/codegen/main/Main.java # swagger-generator/src/main/java/com/mrv/yangtools/codegen/impl/postprocessor/MountPointPostProcessor.java # swagger-generator/src/test/java/com/mrv/yangtools/codegen/issues/Issue45.java
bartoszm
left a comment
bartoszm
left a comment
There was a problem hiding this comment.
Looks mostly OK.
A few things to consider.
Also I have added some commits with improvements but if you do not like them please revert
bartoszm
left a comment
bartoszm
left a comment
There was a problem hiding this comment.
I think all my comments are addressed so as soon as you address remaining ones we are good to ship
…es as well & modify tag assign mechanism for mounted modules
kaja-mohideen
left a comment
kaja-mohideen
left a comment
There was a problem hiding this comment.
Thank you for addressing the comments. Good to merge.
mryznar17
force-pushed
the
SCHEMA_MOUNT_SUPPORT
branch
from
d5380ee to
6a660f2
Compare
4 participants
This PR introduces 2 major changes: