Fix/gcp test pershape skip#355
Merged
Merged
Conversation
…pped The per-shape jobs carry a custom job-level `if`, which makes GitHub implicitly prepend success(). success() returns false when any needs job is skipped, and build-cit is skipped whenever cit_git_repo is empty — so every shape was skipped regardless of the arch input. Use !cancelled() to suppress the implicit success(), and gate explicitly on test-gcp-initialtest so a failed smoke test still blocks while build-cit's skipped/success state is ignored.
…test The first fix only touched the per-shape jobs, but the live run showed test-gcp-initialtest was skipped too: a skipped needed job skips its dependents by default, even when the dependent has no custom `if`. With build-cit skipped (empty cit_git_repo), initialtest was skipped, which in turn skipped every per-shape job that needs it. Add the same !cancelled() + explicit needs-result gate to test-gcp-initialtest so it runs when build-cit is skipped (or succeeds) and init-data succeeded, while a real build failure still blocks it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.