support new first-class denormal attributes#1313
Merged
nunoplopes merged 2 commits intoAliveToolkit:masterfrom Apr 27, 2026
Merged
support new first-class denormal attributes#1313nunoplopes merged 2 commits intoAliveToolkit:masterfrom
nunoplopes merged 2 commits intoAliveToolkit:masterfrom
Conversation
Contributor
It was dropped, it's only handled for bitcode autoupgrade |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
in Feb Matt redid FP denorm attributes so that they're real LLVM attrs instead of strings:
llvm/llvm-project@2502e3b7badc
so alive2 now has some false alarms due to failing to parse the new-style attributes: #1308
we don't want to remove the old string-based code path / tests yet since it looks like the text IR parser does not run the IR auto-upgrader. we can remove this code path / tests once LLVM drops support for the old string attribute syntax.
if @arsenm happens to have time to take a quick look at the test cases attached to this PR, that would be helpful