(Fix) (sway workspace module) persistent workspaces always removed#5072
Open
Lege19 wants to merge 1 commit into
Open
(Fix) (sway workspace module) persistent workspaces always removed#5072Lege19 wants to merge 1 commit into
Lege19 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously the logic in
filter_buttonsdid not check for and handle persistent workspaces properly, with the result that persistent workspaces were erased every time the function was called, then immediately recreated because they were missing.Obviously that's a bit inefficient. But far worse, this was messing with my rice because it broke any transitions that were meant to play.