fix(amodule): prevent crash when cursor timeout fires after destruction#5058
Open
typedrifter wants to merge 1 commit into
Open
fix(amodule): prevent crash when cursor timeout fires after destruction#5058typedrifter wants to merge 1 commit into
typedrifter wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey,
Waybar segfaults when my monitor turns off as stated in #5055
I narrowed it down to AModule::setCursor():
When the window isn't ready, setCursor() schedules a 1-second retry. If the output gets removed and the module is destroyed before that timeout fires it crashes.
The fix stores the timeout connection and disconnects it in the destructor, kinda same as what privacy and idle_inhibitor modules already do.
Tested with my config that was crashing 100% after the monitor was shutdown and turned back on, and the crashes have stopped.
Fixes #5055