Adding test cases for dnsgen 'partiate domain'#4
Open
SrilakshmiSH wants to merge 3 commits intoAlephNullSK:masterfrom
Open
Adding test cases for dnsgen 'partiate domain'#4SrilakshmiSH wants to merge 3 commits intoAlephNullSK:masterfrom
SrilakshmiSH wants to merge 3 commits intoAlephNullSK:masterfrom
Conversation
Collaborator
|
Thanks for the PR, can you please move it to "tests/" folder in the root rather than "dnsgen/"? Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello Patrik,
I have created a test file for partiate domain method using unittest module. I have considered different cases for valid and invalid domain names and have tested for special characters as well using assertEqual(). I'm a beginner in python and new to open source. This being my first contribution, I request you to suggest any improvements.
Thanks,
Sri