Fix creating a fixed element #3612
Merged
+44
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3612 +/- ##
=======================================
Coverage 97.48% 97.48%
=======================================
Files 314 314
Lines 8256 8256
=======================================
Hits 8048 8048
Misses 208 208 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sascha-karnatz
approved these changes
Feb 2, 2026
tvdeyen
force-pushed
the
fix-create-fixed-element
branch
from
f2730fb to
0aaa9ab
Compare
Makes it possible to render the collection at once and to render a fixed element on demand.
We need the tab to exist before appending the element.
tvdeyen
force-pushed
the
fix-create-fixed-element
branch
from
0aaa9ab to
072578d
Compare
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
Collaborator
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
This fixes a bug where the created fixed element does not appear as tab.
In order to fix this we extract the fixed element tab into a partial and render this
in order to make sure the tab to exist before appending the new element.
Checklist