Use css only solution to reduce FOUC #3611
Merged
+13
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of a JS solution, which can fail on some browsers (looking at you Safari) we use a CSS only solution[^1] which gracefully fails and shows the content even if custom elements are not defined yet. Making the page at least somehow usable. [^1]: https://dev.to/stuffbreaker/reducing-fouc-with-web-components-1jnh
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3611 +/- ##
=======================================
Coverage 97.48% 97.48%
=======================================
Files 314 314
Lines 8256 8256
=======================================
Hits 8048 8048
Misses 208 208 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
2 tasks
Collaborator
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
Instead of a JS solution, which can fail on some
browsers (looking at you Safari) we use a CSS only solution1 which gracefully fails and shows the content even if custom elements are not defined yet. Making the page at least somehow usable.
Checklist
Footnotes
https://dev.to/stuffbreaker/reducing-fouc-with-web-components-1jnh ↩